This repository was archived by the owner on Mar 24, 2026. It is now read-only.
Make Colossus building a response object on each request#2231
Merged
NateBrady23 merged 1 commit intoTechEmpower:masterfrom Aug 25, 2016
Merged
Make Colossus building a response object on each request#2231NateBrady23 merged 1 commit intoTechEmpower:masterfrom
NateBrady23 merged 1 commit intoTechEmpower:masterfrom
Conversation
Member
|
Looks good, passes relevant test on travis. Nice catch! Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #2221 and changes the way Colossus responds a JSON payload. The response object is now allocated on each request as per benchmark rules.