Round 13 - Yesod with Postgres

[saurabhnanda]

Yesod with Postgres because the Haskell binding for MySQL has concurrency issues.

• Cleaned up lots of code
• Not dropping down to Wai/Warp level to micro-optimize for the benchmark
• Using the most straight-forward/realistic/idiomatic Yesod code - straight out of the Yesod book (or tutorials)
• The Fortunes benchmark is not working due to some encoding issues. Still investigating. Help would be appreciated.

[knewmanTE]

@saurabhnanda thanks so much for the contribution! We're currently only taking bug fixes and minor changes for our round 13 test. All other merge requests should be opened against our round-14 branch. Would you mind closing this PR and re-opening one against our round-14 branch?

[saurabhnanda]

@knewmanTE It would be great if you could include this in round 13 itself. I really want to make the Yesod benchmarks better, which seem to be suffering just because of the DB choice (MySQL vs Postgres).

All Travis CI tests are passing, so this shouldn't break anything. However, if you still feel that including this in round 13 won't be possible, I'll close and reopen against round 14.

[msmith-techempower]

This file should be merged with frameworks/Haskell/yesod-postgres/.gitignore.

Additionally, is there a reason to not simply add bench to .gitignore?

[saurabhnanda]

Thank you for looking into this. Any other changes that you think are required?

[msmith-techempower]

You are welcome. No, I think the rest looks fine by me

[saurabhnanda]

Made the change. Can't add bench to .gitignore because bench/src contains the source code.

[msmith-techempower]

Looks good to me; if Travis-CI agrees, we'll merge it in.

[saurabhnanda]

So, Travis CI passed. Just curious why did the yesod-postgres benchmark that I added, take approx 24 min whereas all the others are under 2 min?

[NateBrady23]

@saurabhnanda We do some git diffing to try and limit the travis tests to only the frameworks that would be affected by the merge. Thanks for the contribution! Merging!

[saurabhnanda]

Thanks a lot! When will the preliminary data be updated? I'm eager to see how this benchmark performs.

[NateBrady23]

@saurabhnanda I believe we kicked off another prelim round earlier today so this won't be in the next update. There may be one more just to make sure all the environments are working, but if not it will be in the final. After the new servers are up and we get this round done, our hope is the rounds will come much, much faster with an end goal being continuous benchmarking!

[knewmanTE]

I realize this is already merged in, but should yesod-postgres its own directory, or should this test have been added to the benchmark_config for the main yesod directory? ping @msmith-techempower @nbrady-techempower

[msmith-techempower]

... yes, this should have been added to the existing yesod directory.

@nbrady-techempower Is on my list now

[NateBrady23]

@msmith-techempower "Looks good to me; if Travis-CI agrees, we'll merge it in."

I'm follow my master blindly!

[msmith-techempower]

_<

Fine, you're off my list.

[saurabhnanda]

Let me know what needs to be changed.
On 31 Aug 2016 1:51 am, "Mike Smith" notifications@github.com wrote:

_<

Fine, you're off my list.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#2247 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABu0fQ8Qp3lDnyfwS9KUqb9WTIj7T-dks5qlG8bgaJpZM4JvP_o
.

[NateBrady23]

@saurabhnanda I hadn't noticed that this was a separate directory. Ideally, additional a tests for an existing framework would be contained within the same folder. So bringing this in to the existing yesod directory and adding the new test to the existing benchmark_config would be the proper approach.

[saurabhnanda]

@nbrady-techempower Even within the yesod folder, there will have to be two completely separate directories for two separate stack projects - one called yesod-mysql and the other yesod-postgres. Is that acceptable?

Also, what is source_code used for? In this case what should it contain?

[saurabhnanda]

I'm unable to run the yesod-mongodb-raw benchmarks. Did they ever work?

[saurabhnanda]

Did you close round-13 to new PRs? I'm unable to raise a PR against round-13 from the following source: https://github.com/vacationlabs/FrameworkBenchmarks/tree/round-13

[msmith-techempower]

1. It is fine if you have yesod-mysql and yesod-postgres for the purposes of separating source code within the frameworks/Haskell/yesod folder.
2. I have no idea if yesod-mongodb-raw ever worked but we (and many others) have been having issues with MongoDB lately, so I am not convinced as of yet that this is a problem.
3. We closed the round-13 branch, but we are still accepting fixes for round-13. You should open new PRs against the master branch.