Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

Added framework: libevent#2261

Closed
gkbrk wants to merge 1 commit intoTechEmpower:masterfrom
gkbrk:round-14
Closed

Added framework: libevent#2261
gkbrk wants to merge 1 commit intoTechEmpower:masterfrom
gkbrk:round-14

Conversation

@gkbrk
Copy link
Copy Markdown
Contributor

@gkbrk gkbrk commented Sep 5, 2016

No description provided.

@knewmanTE knewmanTE added this to the Round 14 milestone Sep 6, 2016
@nmihajlovski
Copy link
Copy Markdown
Contributor

@gkbrk Wow, this looks very interesting!
Looking forward to seeing the performance results!
Kudos for the hard work!

@knewmanTE
Copy link
Copy Markdown
Contributor

Thanks for the pull request! Just wanted to apologize for the delay in reviewing this and merging it in; we're in the thick of preparing everything for our Round 13 release. As soon as Round 13 is over, we'll get to the Round 14 pull requests!

@gkbrk
Copy link
Copy Markdown
Contributor Author

gkbrk commented Sep 14, 2016

@knewmanTE No worries man, I'm excited for Round 13 as well.

@NateBrady23
Copy link
Copy Markdown
Member

Hi @gkbrk ! Thanks for the contribution! Would you mind adding a README for this framework that includes some information about it and where we can find documentation. I haven't looked too deeply into this yet, but I see you've added an fw_depends libevent / but I don't see any libevent setup in the toolset. Thanks!

@knewmanTE
Copy link
Copy Markdown
Contributor

@gkbrk, is it possible to pull down the relevant framework code from github (or wherever libevent is being hosted)? You've included a rather large file at frameworks/C/libevent/json.h when the only FrameworkBenchmark-specific code lives at frameworks/C/libevent/server.c. As a rule of thumb, we try to limit the code in the FrameworkBenchmarks repo to the actual test implementation and leave the task of downloading and organizing the framework itself to a setup script.

For example, if you look at C/duda, it has fw_depends duda in its setup script, which automatically calls this script to download and configure duda. (fw_depends is a custom function that will search through toolset/setup/linux/* for a script with the provided name and run that script if it exists)

@msmith-techempower msmith-techempower changed the base branch from round-14 to master November 17, 2016 17:22
@msmith-techempower msmith-techempower removed this from the Round 14 milestone Nov 17, 2016
@msmith-techempower
Copy link
Copy Markdown
Member

ping @gkbrk

@NateBrady23
Copy link
Copy Markdown
Member

@gkbrk Going to close this due to inactivity. We're going to start previews right after the new year for the next round. If you'd like to be included please open a new PR targeting the master branch and include the relevant src @knewmanTE mentioned above. Hope to see you in that round and thanks for the contribution! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants