This repository was archived by the owner on Mar 24, 2026. It is now read-only.
set DBHOST properly to fix broken database tests#2267
Merged
msmith-techempower merged 5 commits intoTechEmpower:masterfrom Sep 14, 2016
Merged
set DBHOST properly to fix broken database tests#2267msmith-techempower merged 5 commits intoTechEmpower:masterfrom
msmith-techempower merged 5 commits intoTechEmpower:masterfrom
Conversation
Contributor
|
I have the feeling that we will have official results for Wicket again! 🎆 |
Contributor
Author
|
@martin-g, always happy to be able to get more frameworks passing! Also Travis fails appear to just be the usual bunch of unrelated tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that a few frameworks were assuming that database tests were running against localhost or 127.0.0.1, when in actuality the production environment has a separate machine hosting all of the databases. This fixes the broken database tests in
Java/jooby,Java/wicket, andJavascript/nodejsthat were a result of this problem.