Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUse Revenj routes instead of .NET ones #2399
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
knewmanTE
Dec 8, 2016
Contributor
@zapov could you update your repo with the latest from master? We recently merged in a fix that should get Travis working again so we can verify your test.
|
@zapov could you update your repo with the latest from master? We recently merged in a fix that should get Travis working again so we can verify your test. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zapov
Dec 8, 2016
Contributor
I did.
btw. you've changed metadata so revenj.net is now called revenj, while revenj.jvm is still called revenj.jvm
Also, I think Mono missing from Platform is confusing people thinking that it's probably running on .NET core
|
I did. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
knewmanTE
Dec 8, 2016
Contributor
@zapov thanks! I'm not too familiar with the Platform/Flavor distinction, but perhaps @msmith-techempower can shed some light on it.
Sorry about the test names. Would you mind opening a PR to change it back? Also, could you update both of the test names in that PR to be lowercase so they better match the style of the other tests?
|
@zapov thanks! I'm not too familiar with the Platform/Flavor distinction, but perhaps @msmith-techempower can shed some light on it. Sorry about the test names. Would you mind opening a PR to change it back? Also, could you update both of the test names in that PR to be lowercase so they better match the style of the other tests? |
knewmanTE
merged commit b180441
into
TechEmpower:master
Dec 8, 2016
1 check passed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
zapov
Dec 8, 2016
Contributor
Well, I'm reluctant to change names at this point since this would mean results would drop from previous round.
|
Well, I'm reluctant to change names at this point since this would mean results would drop from previous round. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Hmm... @msmith-techempower @bhauer thoughts? |
zapov commentedDec 6, 2016
Revenj route can specify synchronous response.