Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

Use Revenj routes instead of .NET ones#2399

Merged
knewmanTE merged 1 commit intoTechEmpower:masterfrom
zapov:master
Dec 8, 2016
Merged

Use Revenj routes instead of .NET ones#2399
knewmanTE merged 1 commit intoTechEmpower:masterfrom
zapov:master

Conversation

@zapov
Copy link
Copy Markdown
Contributor

@zapov zapov commented Dec 6, 2016

Revenj route can specify synchronous response.

@knewmanTE
Copy link
Copy Markdown
Contributor

@zapov could you update your repo with the latest from master? We recently merged in a fix that should get Travis working again so we can verify your test.

Revenj route can specify synchronous response.
@zapov
Copy link
Copy Markdown
Contributor Author

zapov commented Dec 8, 2016

I did.
btw. you've changed metadata so revenj.net is now called revenj, while revenj.jvm is still called revenj.jvm
Also, I think Mono missing from Platform is confusing people thinking that it's probably running on .NET core

@knewmanTE
Copy link
Copy Markdown
Contributor

@zapov thanks! I'm not too familiar with the Platform/Flavor distinction, but perhaps @msmith-techempower can shed some light on it.

Sorry about the test names. Would you mind opening a PR to change it back? Also, could you update both of the test names in that PR to be lowercase so they better match the style of the other tests?

@zapov
Copy link
Copy Markdown
Contributor Author

zapov commented Dec 8, 2016

Well, I'm reluctant to change names at this point since this would mean results would drop from previous round.

@knewmanTE
Copy link
Copy Markdown
Contributor

Hmm... @msmith-techempower @bhauer thoughts?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants