New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Revenj routes instead of .NET ones #2399

Merged
merged 1 commit into from Dec 8, 2016

Conversation

Projects
None yet
2 participants
@zapov
Contributor

zapov commented Dec 6, 2016

Revenj route can specify synchronous response.

@knewmanTE

This comment has been minimized.

Show comment
Hide comment
@knewmanTE

knewmanTE Dec 8, 2016

Contributor

@zapov could you update your repo with the latest from master? We recently merged in a fix that should get Travis working again so we can verify your test.

Contributor

knewmanTE commented Dec 8, 2016

@zapov could you update your repo with the latest from master? We recently merged in a fix that should get Travis working again so we can verify your test.

Use Revenj routes instead of .NET ones
Revenj route can specify synchronous response.
@zapov

This comment has been minimized.

Show comment
Hide comment
@zapov

zapov Dec 8, 2016

Contributor

I did.
btw. you've changed metadata so revenj.net is now called revenj, while revenj.jvm is still called revenj.jvm
Also, I think Mono missing from Platform is confusing people thinking that it's probably running on .NET core

Contributor

zapov commented Dec 8, 2016

I did.
btw. you've changed metadata so revenj.net is now called revenj, while revenj.jvm is still called revenj.jvm
Also, I think Mono missing from Platform is confusing people thinking that it's probably running on .NET core

@knewmanTE

This comment has been minimized.

Show comment
Hide comment
@knewmanTE

knewmanTE Dec 8, 2016

Contributor

@zapov thanks! I'm not too familiar with the Platform/Flavor distinction, but perhaps @msmith-techempower can shed some light on it.

Sorry about the test names. Would you mind opening a PR to change it back? Also, could you update both of the test names in that PR to be lowercase so they better match the style of the other tests?

Contributor

knewmanTE commented Dec 8, 2016

@zapov thanks! I'm not too familiar with the Platform/Flavor distinction, but perhaps @msmith-techempower can shed some light on it.

Sorry about the test names. Would you mind opening a PR to change it back? Also, could you update both of the test names in that PR to be lowercase so they better match the style of the other tests?

@knewmanTE knewmanTE merged commit b180441 into TechEmpower:master Dec 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@zapov

This comment has been minimized.

Show comment
Hide comment
@zapov

zapov Dec 8, 2016

Contributor

Well, I'm reluctant to change names at this point since this would mean results would drop from previous round.

Contributor

zapov commented Dec 8, 2016

Well, I'm reluctant to change names at this point since this would mean results would drop from previous round.

@knewmanTE

This comment has been minimized.

Show comment
Hide comment
@knewmanTE

knewmanTE Dec 8, 2016

Contributor

Hmm... @msmith-techempower @bhauer thoughts?

Contributor

knewmanTE commented Dec 8, 2016

Hmm... @msmith-techempower @bhauer thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment