Conversation
|
Could we just delete the implementation instead of commenting it out? |
|
@LadyMozzarella We may be adding redis back in, so for tests that are failing because redis was removed I was just planning on keeping the author's original implementation in code. It may be helpful for people who are looking at the current implementation, wondering what the intent was. Since I don't know if they would have done things differently had they known they couldn't use redis, this might be the best way for now. |
|
Nonetheless, this one passed locally but isn't passing travis so I will have to revisit in a moment. |
|
In that case, can you add a comment with that information while you're in there? |
|
Will do. |
|
Because of the way the author wrote this test, (and possibly the way hapi works), a working db connection is expected on startup. Combined the default test with the mongodb tests to make it the default. |
|
All green! merging |
* remove redis implementation * combine default test
2 participants
The default test for hapi was also trying to spin up redis. We currently do not have a working redis setup.