Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUse /etc/hosts aliases instead of $DBHOST and other #2475
Conversation
nbrady-techempower
added some commits
Jan 3, 2017
| @@ -20,7 +20,7 @@ query_levels=[1, 5,10,15,20] | ||
| threads=8 | ||
| mode=benchmark | ||
| os=linux | ||
| server_host=127.0.0.1 | ||
| server_host=TFB-server |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
msmith-techempower
Jan 3, 2017
Member
There was once, long ago, an implementation similar to this; we removed it because some frameworks could not resolve names for reasons we could not explain. Hopefully, this is no longer the case....
msmith-techempower
Jan 3, 2017
Member
There was once, long ago, an implementation similar to this; we removed it because some frameworks could not resolve names for reasons we could not explain. Hopefully, this is no longer the case....
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nbrady-techempower
Jan 3, 2017
Member
If it is the case, those frameworks can still do the sed stuff they're doing now and pull in the ip from the /etc/hosts file.
nbrady-techempower
Jan 3, 2017
Member
If it is the case, those frameworks can still do the sed stuff they're doing now and pull in the ip from the /etc/hosts file.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
msmith-techempower
Jan 3, 2017
Member
I see this being done in travis and vagrant, but I don't see this setup happening in the general case (like our production code): you should plan on adding that in.
msmith-techempower
Jan 3, 2017
Member
I see this being done in travis and vagrant, but I don't see this setup happening in the general case (like our production code): you should plan on adding that in.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nbrady-techempower
Jan 3, 2017
Member
This would be part of the setup. So it would be something done manually (see the linked installation guide) or did you have something else in mind?
nbrady-techempower
Jan 3, 2017
Member
This would be part of the setup. So it would be something done manually (see the linked installation guide) or did you have something else in mind?
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nbrady-techempower
Jan 4, 2017
Member
@msmith-techempower Here is the corresponding documentation: https://github.com/TechEmpower/TFB-Documentation/pull/58/files
All of the modified tests pass. We can leave $DBHOST and other environment variables available for now but push future tests and updates toward TFB-database, TFB-client, TFB-server.
If this is good for you, we can merge this in and I can update a lot of the others.
|
@msmith-techempower Here is the corresponding documentation: https://github.com/TechEmpower/TFB-Documentation/pull/58/files All of the modified tests pass. We can leave If this is good for you, we can merge this in and I can update a lot of the others. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nbrady-techempower
Jan 5, 2017
Member
@volyrique Thanks. Going through some of the setups, to test this change. At a quick glance I misread the port as 5432 and associated it with postgres.
|
@volyrique Thanks. Going through some of the setups, to test this change. At a quick glance I misread the port as |
nbrady-techempower commentedJan 3, 2017
I noticed that
TFB-clientTFB-databaseandTFB-serverwere already being set up in the/etc/hostsfile during vagrant bootstrapping. I've updated the travis setup to do the same. Before something like this gets merged in, a note in the Installation Guide for those not using vagrant is needed.Ideally, we would no longer need to use $DBHOST and other environment variables for IP addresses. We would also no longer need to use
sedin setup files to replace IPs. I've edited a few frameworks here as a proof of concept, but also, the suite usesbenchmark.cfg.exampleif abenchmark.cfgdoesn't exist. So for the sake of this travis run,$DBHOST=TFB-database.