New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use /etc/hosts aliases instead of $DBHOST and other #2475

Merged
merged 3 commits into from Jan 6, 2017

Conversation

Projects
None yet
3 participants
@nbrady-techempower
Member

nbrady-techempower commented Jan 3, 2017

I noticed that TFB-client TFB-database and TFB-server were already being set up in the /etc/hosts file during vagrant bootstrapping. I've updated the travis setup to do the same. Before something like this gets merged in, a note in the Installation Guide for those not using vagrant is needed.

Ideally, we would no longer need to use $DBHOST and other environment variables for IP addresses. We would also no longer need to use sed in setup files to replace IPs. I've edited a few frameworks here as a proof of concept, but also, the suite uses benchmark.cfg.example if a benchmark.cfg doesn't exist. So for the sake of this travis run, $DBHOST=TFB-database.

@@ -20,7 +20,7 @@ query_levels=[1, 5,10,15,20]
threads=8
mode=benchmark
os=linux
server_host=127.0.0.1
server_host=TFB-server

This comment has been minimized.

@msmith-techempower

msmith-techempower Jan 3, 2017

Member

There was once, long ago, an implementation similar to this; we removed it because some frameworks could not resolve names for reasons we could not explain. Hopefully, this is no longer the case....

@msmith-techempower

msmith-techempower Jan 3, 2017

Member

There was once, long ago, an implementation similar to this; we removed it because some frameworks could not resolve names for reasons we could not explain. Hopefully, this is no longer the case....

This comment has been minimized.

@nbrady-techempower

nbrady-techempower Jan 3, 2017

Member

If it is the case, those frameworks can still do the sed stuff they're doing now and pull in the ip from the /etc/hosts file.

@nbrady-techempower

nbrady-techempower Jan 3, 2017

Member

If it is the case, those frameworks can still do the sed stuff they're doing now and pull in the ip from the /etc/hosts file.

This comment has been minimized.

@msmith-techempower

msmith-techempower Jan 3, 2017

Member

I see this being done in travis and vagrant, but I don't see this setup happening in the general case (like our production code): you should plan on adding that in.

@msmith-techempower

msmith-techempower Jan 3, 2017

Member

I see this being done in travis and vagrant, but I don't see this setup happening in the general case (like our production code): you should plan on adding that in.

This comment has been minimized.

@nbrady-techempower

nbrady-techempower Jan 3, 2017

Member

This would be part of the setup. So it would be something done manually (see the linked installation guide) or did you have something else in mind?

@nbrady-techempower

nbrady-techempower Jan 3, 2017

Member

This would be part of the setup. So it would be something done manually (see the linked installation guide) or did you have something else in mind?

@nbrady-techempower

This comment has been minimized.

Show comment
Hide comment
@nbrady-techempower

nbrady-techempower Jan 4, 2017

Member

@msmith-techempower Here is the corresponding documentation: https://github.com/TechEmpower/TFB-Documentation/pull/58/files

All of the modified tests pass. We can leave $DBHOST and other environment variables available for now but push future tests and updates toward TFB-database, TFB-client, TFB-server.

If this is good for you, we can merge this in and I can update a lot of the others.

Member

nbrady-techempower commented Jan 4, 2017

@msmith-techempower Here is the corresponding documentation: https://github.com/TechEmpower/TFB-Documentation/pull/58/files

All of the modified tests pass. We can leave $DBHOST and other environment variables available for now but push future tests and updates toward TFB-database, TFB-client, TFB-server.

If this is good for you, we can merge this in and I can update a lot of the others.

@nbrady-techempower

This comment has been minimized.

Show comment
Hide comment
@nbrady-techempower

nbrady-techempower Jan 5, 2017

Member

@volyrique Thanks. Going through some of the setups, to test this change. At a quick glance I misread the port as 5432 and associated it with postgres.

Member

nbrady-techempower commented Jan 5, 2017

@volyrique Thanks. Going through some of the setups, to test this change. At a quick glance I misread the port as 5432 and associated it with postgres.

@msmith-techempower msmith-techempower merged commit c094138 into TechEmpower:master Jan 6, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@nbrady-techempower nbrady-techempower deleted the nbrady-techempower:hosts branch May 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment