This repository was archived by the owner on Mar 24, 2026. It is now read-only.
Fix broken wicket db tests by downgrading the mysql connector#2603
Merged
michaelhixson merged 1 commit intoTechEmpower:masterfrom Mar 22, 2017
Merged
Conversation
Version 6.x of the connector is apparently more opinionated about time zones. All of the db tests were failing with exceptions like this: java.sql.SQLException: The server time zone value 'CDT' is unrecognized or represents more than one time zone. You must configure either the server or JDBC driver (via the serverTimezone configuration property) to use a more specifc time zone value if you want to utilize time zone support. Maybe it's making a valid point that we should address, maybe not. But right now mysql-connector-java 6.x is a "development release". Let's use the stable release (5.x) instead, which is what every other framework that uses Java and mysql is doing already.
Contributor
|
The tests pass here and AFAIK they pass at Travis too. |
Contributor
|
It seems the DB tests fail for Round 14 Preview 1: https://www.techempower.com/benchmarks/previews/round14/r13-vs-r14p1.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 6.x of the connector is apparently more opinionated about time zones. All of the db tests were failing with exceptions like this:
Maybe it's making a valid point that we should address, maybe not. But right now mysql-connector-java 6.x is a "development release". Let's use the stable release (5.x) instead, which is what every other framework that uses Java and mysql is doing already.