This repository was archived by the owner on Mar 24, 2026. It is now read-only.
Make wicket encode its fortunes response in UTF-8#2664
Merged
NateBrady23 merged 1 commit intoTechEmpower:masterfrom Apr 6, 2017
Merged
Make wicket encode its fortunes response in UTF-8#2664NateBrady23 merged 1 commit intoTechEmpower:masterfrom
NateBrady23 merged 1 commit intoTechEmpower:masterfrom
Conversation
It appeared to be using the system default charset instead, which was not necessarily UTF-8. I removed the initialCapacity argument for the ArrayList because there's no good reason to set it to 10,000. Since the test requirements state that the list shouldn't be sized using foreknowledge of the row count, we might as well trust ArrayList's defaults.
|
Thanks @michaelhixson for contributing to The Framework Benchmarks! @martin-g and @dashorst, code you've worked on has been modified. If you have the chance, please review. If you wish to unsubscribe from these notices, please open a Pull Request with the commit message |
martin-g
approved these changes
Apr 5, 2017
Contributor
|
Thank you, @michaelhixson ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This replaces a previous PR #2662, incorporating the feedback.)
This should repair the wicket fortune test on ServerCentral, which is currently failing.
It appeared to be using the system default charset instead, which was not necessarily UTF-8.
I removed the
initialCapacityargument for theArrayListbecause there's no good reason to set it to 10,000. Since the test requirements state that the list shouldn't be sized using foreknowledge of the row count, we might as well trustArrayList's defaults.