Share the results folder

[joanhey]

in vagrant, for easier view and manage.
Still the contents in the folder are ignored by Git.

[mention-bot]

Thanks @joanhey for contributing to The Framework Benchmarks! @msmith-techempower, @gregw, @cmsimike, @achlipala, @zane-techempower, @judofyr, @will and @TechEmpower, code you've worked on has been modified. If you have the chance, please review. If you wish to unsubscribe from these notices, please open a Pull Request with the commit message [ci skip] and your github name added to the userBlacklist array in the .mention-bot file.

[mention-bot]

Thanks @joanhey for contributing to The Framework Benchmarks! @msmith-techempower, @gregw, @cmsimike, @achlipala, @zane-techempower, @judofyr, @will and @TechEmpower, code you've worked on has been modified. If you have the chance, please review. If you wish to unsubscribe from these notices, please open a Pull Request with the commit message [ci skip] and your github name added to the userBlacklist array in the .mention-bot file.

[nbrady-techempower]

@joanhey I'd have to play with this on monday. My concern is what happens on windows when you run the tfb --clean-all command or otherwise try and remove the results directory. I don't think this would work.

[nbrady-techempower]

@joanhey I'd have to play with this on monday. My concern is what happens on windows when you run the tfb --clean-all command or otherwise try and remove the results directory. I don't think this would work.

[joanhey]

It is really useful, perhaps tfb --clean-all, should delete the contents in the folder and not the folder.
Because remove the directory, will give problems, the same that remove the toolset directory or any other.

[joanhey]

It is really useful, perhaps tfb --clean-all, should delete the contents in the folder and not the folder.
Because remove the directory, will give problems, the same that remove the toolset directory or any other.

[nbrady-techempower]

@joanhey Those are fair points. I believe there were some reasons for not doing this before, some other intricacies of the toolset that may be resolved now. I'll do some testing on this and make appropriate changes. I agree with you.

[nbrady-techempower]

@joanhey Those are fair points. I believe there were some reasons for not doing this before, some other intricacies of the toolset that may be resolved now. I'll do some testing on this and make appropriate changes. I agree with you.

[nbrady-techempower]

Hey @joanhey closing for #2732 - Thanks for pointing this out. I did it in a way that doesn't require the results directory being in the repo as well.

[nbrady-techempower]

Hey @joanhey closing for #2732 - Thanks for pointing this out. I did it in a way that doesn't require the results directory being in the repo as well.