Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

Share the results folder#2712

Closed
joanhey wants to merge 1 commit intoTechEmpower:masterfrom
joanhey:vagrant
Closed

Share the results folder#2712
joanhey wants to merge 1 commit intoTechEmpower:masterfrom
joanhey:vagrant

Conversation

@joanhey
Copy link
Copy Markdown
Contributor

@joanhey joanhey commented Apr 22, 2017

in vagrant, for easier view and manage.
Still the contents in the folder are ignored by Git.

in vagrant, for easier view and manage.
Still the contents in the folder are ignored by Git.
@mention-bot
Copy link
Copy Markdown

Thanks @joanhey for contributing to The Framework Benchmarks! @msmith-techempower, @gregw, @cmsimike, @achlipala, @zane-techempower, @judofyr, @will and @TechEmpower, code you've worked on has been modified. If you have the chance, please review. If you wish to unsubscribe from these notices, please open a Pull Request with the commit message [ci skip] and your github name added to the userBlacklist array in the .mention-bot file.

@NateBrady23
Copy link
Copy Markdown
Member

@joanhey I'd have to play with this on monday. My concern is what happens on windows when you run the tfb --clean-all command or otherwise try and remove the results directory. I don't think this would work.

@joanhey
Copy link
Copy Markdown
Contributor Author

joanhey commented Apr 24, 2017

It is really useful, perhaps tfb --clean-all, should delete the contents in the folder and not the folder.
Because remove the directory, will give problems, the same that remove the toolset directory or any other.

@NateBrady23
Copy link
Copy Markdown
Member

@joanhey Those are fair points. I believe there were some reasons for not doing this before, some other intricacies of the toolset that may be resolved now. I'll do some testing on this and make appropriate changes. I agree with you.

@NateBrady23
Copy link
Copy Markdown
Member

Hey @joanhey closing for #2732 - Thanks for pointing this out. I did it in a way that doesn't require the results directory being in the repo as well.

@joanhey joanhey deleted the vagrant branch April 28, 2017 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants