Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upShare the results folder #2712
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mention-bot
Apr 22, 2017
Thanks @joanhey for contributing to The Framework Benchmarks! @msmith-techempower, @gregw, @cmsimike, @achlipala, @zane-techempower, @judofyr, @will and @TechEmpower, code you've worked on has been modified. If you have the chance, please review. If you wish to unsubscribe from these notices, please open a Pull Request with the commit message [ci skip] and your github name added to the userBlacklist array in the .mention-bot file.
mention-bot
commented
Apr 22, 2017
|
Thanks @joanhey for contributing to The Framework Benchmarks! @msmith-techempower, @gregw, @cmsimike, @achlipala, @zane-techempower, @judofyr, @will and @TechEmpower, code you've worked on has been modified. If you have the chance, please review. If you wish to unsubscribe from these notices, please open a Pull Request with the commit message |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nbrady-techempower
Apr 22, 2017
Member
@joanhey I'd have to play with this on monday. My concern is what happens on windows when you run the tfb --clean-all command or otherwise try and remove the results directory. I don't think this would work.
|
@joanhey I'd have to play with this on monday. My concern is what happens on windows when you run the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
joanhey
Apr 24, 2017
Contributor
It is really useful, perhaps tfb --clean-all, should delete the contents in the folder and not the folder.
Because remove the directory, will give problems, the same that remove the toolset directory or any other.
|
It is really useful, perhaps |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
nbrady-techempower
Apr 24, 2017
Member
@joanhey Those are fair points. I believe there were some reasons for not doing this before, some other intricacies of the toolset that may be resolved now. I'll do some testing on this and make appropriate changes. I agree with you.
|
@joanhey Those are fair points. I believe there were some reasons for not doing this before, some other intricacies of the toolset that may be resolved now. I'll do some testing on this and make appropriate changes. I agree with you. |
joanhey commentedApr 22, 2017
in vagrant, for easier view and manage.
Still the contents in the folder are ignored by Git.