This repository was archived by the owner on Mar 24, 2026. It is now read-only.
Remove the includeos-mana framework and docker#3187
Merged
msmith-techempower merged 1 commit intoTechEmpower:masterfrom Jan 18, 2018
Merged
Remove the includeos-mana framework and docker#3187msmith-techempower merged 1 commit intoTechEmpower:masterfrom
msmith-techempower merged 1 commit intoTechEmpower:masterfrom
Conversation
In its current form, the includeos-mana framework test is not releasing port 8080, causing many other frameworks to fail. Our toolset isn't equipped to handle docker properly right now. We would welcome a PR that reintroduces includeos-mana without docker.
|
Thanks @michaelhixson for contributing to The Framework Benchmarks! @TechEmpower, code you've worked on has been modified. If you have the chance, please review. If you wish to unsubscribe from these notices, please open a Pull Request with the commit message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In its current form, the includeos-mana framework test is not releasing
port 8080, causing many other frameworks to fail. Our toolset isn't
equipped to handle docker properly right now. We would welcome a PR
that reintroduces includeos-mana without docker.
@ciarancourtney FYI