Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

use ikitommi/immutant-web#3256

Merged
NateBrady23 merged 1 commit intoTechEmpower:masterfrom
ikitommi:master
Feb 11, 2018
Merged

use ikitommi/immutant-web#3256
NateBrady23 merged 1 commit intoTechEmpower:masterfrom
ikitommi:master

Conversation

@ikitommi
Copy link
Copy Markdown
Contributor

@ikitommi ikitommi commented Feb 5, 2018

use ikitommi/immutant-web, less noise, much better perf.

@NateBrady23
Copy link
Copy Markdown
Member

Hi @ikitommi -
Would you be able to take a look at the updates test for Closure while you're in there? It is either not persisting updates to the database or returning a response before the updates were committed.

@ikitommi
Copy link
Copy Markdown
Contributor Author

"test for Closure", I'm not sure what that means. I guess it doesn't relate to this PR? If there is some other clojure benchmark with a problem, I can try to find the persons from Clojure Slack.

cheers,

Tommi

@NateBrady23
Copy link
Copy Markdown
Member

Thanks tommi, it was taken care of already

@NateBrady23 NateBrady23 merged commit f578901 into TechEmpower:master Feb 11, 2018
@ikitommi
Copy link
Copy Markdown
Contributor Author

Hi. Sadly, this doesn't seem to be part of the valentine / round15. Is there any change of getting feedback on the perf?

@ikitommi
Copy link
Copy Markdown
Contributor Author

About to release the library next week, would have loved to get real numbers on this.

@msmith-techempower
Copy link
Copy Markdown
Member

https://tfb-status.techempower.com/ you can see live numbers as the benchmarks are continuously run

@ikitommi
Copy link
Copy Markdown
Contributor Author

Thanks for the info. I'll parse the results when they arrive (can see from test meta-data when the changed have been applied). I guess the official site & numbers will update next time in far future?

@ikitommi
Copy link
Copy Markdown
Contributor Author

ikitommi commented Mar 5, 2018

It seems that the live data is not running the latest code, https://tfb-status.techempower.com/results/a1110174-a3af-4c2e-a4e1-bfcdca8bd8eb. Any guess when the code in this PR would get a result?

@cjnething
Copy link
Copy Markdown
Contributor

Hi @ikitommi it looks like this run has your code. Let me know if that doesn't look right!

@ikitommi
Copy link
Copy Markdown
Contributor Author

ikitommi commented Mar 5, 2018

Thanks. It seems that 306/444 have failed on that run, including reitit. Coudn't figure out why: https://tfb-status.techempower.com/unzip/results.2018-03-04-21-34-49-221.zip/reitit/out.txt

@cjnething
Copy link
Copy Markdown
Contributor

@ikitommi We're in the middle of switching the frameworks over to Docker and it looks like this framework hasn't been switched over yet, hence the Docker errors.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants