This repository was archived by the owner on Mar 24, 2026. It is now read-only.
JS/hapi fix updates test#3258
Merged
NateBrady23 merged 1 commit intoTechEmpower:masterfrom Feb 6, 2018
Merged
Conversation
zloster
pushed a commit
to zloster/FrameworkBenchmarks
that referenced
this pull request
Feb 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the middle of fixing the query update test here, I realized that #3210 wasn't actually checking both casing variations of the world table as "Select * from World" and "Select * from world" were the same table. That's been fixed there. Hapi was likely committing the updates. In any event, I've cleaned up some things here and removed the bluebird promise library in favor of node's native async/await.