This repository was archived by the owner on Mar 24, 2026. It is now read-only.
Update facil.io version and add docker file#3359
Closed
boazsegev wants to merge 1 commit intoTechEmpower:masterfrom
boazsegev:master
Closed
Update facil.io version and add docker file#3359boazsegev wants to merge 1 commit intoTechEmpower:masterfrom boazsegev:master
boazsegev wants to merge 1 commit intoTechEmpower:masterfrom
boazsegev:master
Conversation
The main relevant difference in the updated facil.io version is the memory allocator (I wrote a custom memory allocator that should minimize lock contention). I also added a dockerfile, as I understand that this is where things are headed. However, I didn’t know how to test the dockerfile… any guidance would be appreciated (I especially wonder about the use of `ENV CC`).
Member
|
@boazsegev You'll want to look at the docker branch. As a matter of fact, since all the C frameworks have already been moved to docker, if you could do this update there it would be more helpful. The next round will come from the changes on that branch. Testing is done the same way, The dockerfile is the name of the test, you'll notice that in that branch. So I'm going to close this here and please re-open to target the docker branch. If you're having trouble just ping me in a new PR and I can help you from there! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main relevant difference in the updated facil.io version is the memory allocator (I wrote a custom memory allocator that should minimize lock contention).
It's possible to test the new version without the multi-threaded memory allocator by using:
I also added a dockerfile, as I understand that this is where things are headed...
...however, I didn’t know how to test the dockerfile. Any guidance would be appreciated (I especially wonder about the use of
ENV CC).