Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

Add Reindexer database server as database type#3967

Closed
olegator77 wants to merge 6 commits intoTechEmpower:masterfrom
olegator77:master
Closed

Add Reindexer database server as database type#3967
olegator77 wants to merge 6 commits intoTechEmpower:masterfrom
olegator77:master

Conversation

@olegator77
Copy link
Copy Markdown

Hi!
I've introduced Reindexer database to toolset.
Also there are added Golang fasthttp-reindexer test (as extra subtest of existing fasthttp test)

@olegator77
Copy link
Copy Markdown
Author

olegator77 commented Aug 6, 2018

Hi! I've investigated about CI error status - changes to toolset folder are force run of every framework tests in CI.
But It seems, that few frameworks tests in master branch can't pass CI tests their self.

So, please help - how to pass CI test in this case?

Tnx.
Oleg

@cjnething
Copy link
Copy Markdown
Contributor

Hi @olegator77 would you mind resolving this merge conflict? Thanks!

@cjnething
Copy link
Copy Markdown
Contributor

Thanks @olegator77! I'll request a reviewer

@olegator77
Copy link
Copy Markdown
Author

@cjnething thanks, will wait for review!

@NateBrady23
Copy link
Copy Markdown
Member

Thanks for taking the time to open this PR. Right now, we're not ready to add any new databases to the toolset. We're hoping in the near future to make it easier to add databases without touching the core toolset code (like simply dropping a new directory under databases). When that time comes, we'll be able to do a more thorough review of potential new databases.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants