Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

[DNMY] Giraffe updates#4057

Closed
dv00d00 wants to merge 2 commits intoTechEmpower:masterfrom
dv00d00:giraffe-update-3x
Closed

[DNMY] Giraffe updates#4057
dv00d00 wants to merge 2 commits intoTechEmpower:masterfrom
dv00d00:giraffe-update-3x

Conversation

@dv00d00
Copy link
Copy Markdown
Contributor

@dv00d00 dv00d00 commented Sep 22, 2018

Changes:

  • updated nuget packages
  • added token router 1.0
  • used token router in stock version
  • copied code from giraffe to render view into byte array
  • removed custom rendering code
  • updated classification of custom fortunes to realistic micro
  • updated readme

@dustinmoris would appreciate a review from you

added token router 1.0
used token router in stock version
copied code from giraffe to render view into byte array
removed custom rendering code
updated classification of custom fortunes to realistic micro
updated readme
@dv00d00 dv00d00 changed the title Giraffe updates [DNMY] Giraffe updates Sep 22, 2018
@dustinmoris
Copy link
Copy Markdown
Contributor

Giraffe 3.1.0 has been released now so I think you can probably trim this PR even further down, as there is no need for the custom cache anymore ;)

@NateBrady23
Copy link
Copy Markdown
Member

@dv00d00 Do you want this merged or are we still waiting on someone?

@michaelhixson
Copy link
Copy Markdown
Contributor

I'm closing this PR because it still has the "do not merge yet" tag and there hasn't been any activity in a few months. Feel free to re-open when you think it's ready to be merged.

@dv00d00 dv00d00 deleted the giraffe-update-3x branch January 28, 2019 22:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants