New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed errors in cake/Fortune, cake/db, php-orm/db #682

Merged
merged 1 commit into from Aug 7, 2014

Conversation

Projects
None yet
6 participants
@remiq
Contributor

remiq commented Dec 29, 2013

Fixed syntax error in cake/app/Controllers/FortunesController
Corrected name of table in cake/app/Model/World.php.
Corrected name of table in php/models/World.php.

Also:
Changed method of loading fortunes from raw SQL to production-grade ORM.

Fixed syntax error in FortunesController.php.
Changed method of loading fortunes from raw SQL to  production-grade ORM.
Corrected name of table in cake/app/Model/World.php.
Corrected name of table in php/models/World.php.
@msmith-techempower

This comment has been minimized.

Show comment
Hide comment
@msmith-techempower

msmith-techempower Jan 13, 2014

Member

@remiq While the tests run, the output do not match the rules laid out here: http://www.techempower.com/benchmarks/#section=code

Here is your output: https://gist.github.com/msmith-techempower/8404715

Specifically, the formatting for db and query are too verbose. The db test should always return a single JSON object with the keys 'id' and 'randomNumber' while the query test should always return a JSON array containing 1-500 objects with the keys 'id' and 'randomNumber'.

Member

msmith-techempower commented Jan 13, 2014

@remiq While the tests run, the output do not match the rules laid out here: http://www.techempower.com/benchmarks/#section=code

Here is your output: https://gist.github.com/msmith-techempower/8404715

Specifically, the formatting for db and query are too verbose. The db test should always return a single JSON object with the keys 'id' and 'randomNumber' while the query test should always return a JSON array containing 1-500 objects with the keys 'id' and 'randomNumber'.

// stuffing in the dynamic data
$results[]['Fortune'] = [

This comment has been minimized.

@Dith3r

Dith3r Feb 3, 2014

Contributor

this syntax is ok in php 5.4 which should be used in tests.

@Dith3r

Dith3r Feb 3, 2014

Contributor

this syntax is ok in php 5.4 which should be used in tests.

@jlucier-techempower

This comment has been minimized.

Show comment
Hide comment
@jlucier-techempower

jlucier-techempower Jun 11, 2014

Contributor

We ran your code and only json and plaintext passed.

Output: https://gist.github.com/jlucier-techempower/ae970903aedb72eeeeda

db and query failed validation. The rules for those tests can be found here: http://www.techempower.com/benchmarks/#section=code&hw=peak&test=json

Contributor

jlucier-techempower commented Jun 11, 2014

We ran your code and only json and plaintext passed.

Output: https://gist.github.com/jlucier-techempower/ae970903aedb72eeeeda

db and query failed validation. The rules for those tests can be found here: http://www.techempower.com/benchmarks/#section=code&hw=peak&test=json

@hamiltont

This comment has been minimized.

Show comment
Hide comment
@hamiltont

hamiltont Aug 6, 2014

Contributor

Re:

Changed method of loading fortunes from raw SQL to production-grade ORM

I think you should also be updating the benchmark_profile

Contributor

hamiltont commented Aug 6, 2014

Re:

Changed method of loading fortunes from raw SQL to production-grade ORM

I think you should also be updating the benchmark_profile

@hamiltont

This comment has been minimized.

Show comment
Hide comment
@hamiltont

hamiltont Aug 6, 2014

Contributor

Oh, scratch that. cake already lists "orm": "Full", so this really is a bug fix. Nice!

Contributor

hamiltont commented Aug 6, 2014

Oh, scratch that. cake already lists "orm": "Full", so this really is a bug fix. Nice!

@hamiltont hamiltont merged commit f3d407d into TechEmpower:master Aug 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment