Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed errors in cake/Fortune, cake/db, php-orm/db #682
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
msmith-techempower
Jan 13, 2014
Member
@remiq While the tests run, the output do not match the rules laid out here: http://www.techempower.com/benchmarks/#section=code
Here is your output: https://gist.github.com/msmith-techempower/8404715
Specifically, the formatting for db and query are too verbose. The db test should always return a single JSON object with the keys 'id' and 'randomNumber' while the query test should always return a JSON array containing 1-500 objects with the keys 'id' and 'randomNumber'.
|
@remiq While the tests run, the output do not match the rules laid out here: http://www.techempower.com/benchmarks/#section=code Here is your output: https://gist.github.com/msmith-techempower/8404715 Specifically, the formatting for |
Dith3r
reviewed
Feb 3, 2014
| // stuffing in the dynamic data | ||
| $results[]['Fortune'] = [ |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jlucier-techempower
added
the
benchmark toolset
label
Jun 11, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
jlucier-techempower
Jun 11, 2014
Contributor
We ran your code and only json and plaintext passed.
Output: https://gist.github.com/jlucier-techempower/ae970903aedb72eeeeda
db and query failed validation. The rules for those tests can be found here: http://www.techempower.com/benchmarks/#section=code&hw=peak&test=json
|
We ran your code and only Output: https://gist.github.com/jlucier-techempower/ae970903aedb72eeeeda
|
aschneider-techempower
added
the
update request
label
Jul 17, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hamiltont
Aug 6, 2014
Contributor
Re:
Changed method of loading fortunes from raw SQL to production-grade ORM
I think you should also be updating the benchmark_profile
|
Re:
I think you should also be updating the |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
hamiltont
Aug 6, 2014
Contributor
Oh, scratch that. cake already lists "orm": "Full", so this really is a bug fix. Nice!
|
Oh, scratch that. cake already lists |
remiq commentedDec 29, 2013
Fixed syntax error in cake/app/Controllers/FortunesController
Corrected name of table in cake/app/Model/World.php.
Corrected name of table in php/models/World.php.
Also:
Changed method of loading fortunes from raw SQL to production-grade ORM.