Skip to content

Rust framework Anansi (not accepting requests from client machine) #7842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 7, 2023
Merged

Rust framework Anansi (not accepting requests from client machine) #7842

merged 7 commits into from
Feb 7, 2023

Conversation

@saru-tora
Copy link
Contributor

@saru-tora saru-tora commented Jan 3, 2023

This framework does not seem to accept requests during tests for some reason.

@saru-tora saru-tora mentioned this pull request Jan 3, 2023
Closed
@NateBrady23
Copy link
Member

NateBrady23 commented Jan 18, 2023

Sorry I haven't been able to take a look at this yet @saru-tora. One of the most common problems is the server binding to localhost and not 0.0.0.0. I can't see that part of the framework code here. Can you confirm?

@joanhey
Copy link
Contributor

joanhey commented Jan 19, 2023

Failed compiling:
https://github.com/TechEmpower/FrameworkBenchmarks/actions/runs/3832471255/jobs/6763475162#step:9:982

@saru-tora
Copy link
Contributor Author

saru-tora commented Jan 21, 2023 •
edited
Loading

Changing it to 0.0.0.0 made it pass the JSON and plaintext test @nbrady-techempower. However, for the db test, now it says it can't find the randomNumber column.

Actually, it might be a framework issue. I'm looking into it.

Okay, it should all work now.

@NateBrady23
Copy link
Member

NateBrady23 commented Feb 2, 2023

@saru-tora Great! Glad that worked. Is this ready to be moved out of draft?

@saru-tora
Copy link
Contributor Author

saru-tora commented Feb 3, 2023

@nbrady-techempower The code is ready, but I'm not sure about instruction 5 in the README:

"Edit .github/workflows/build.yml to ensure that Github Actions will automatically run our verification tests against your new test. This file is kept in alphabetical order, so find where TESTDIR=Rust/anansi should be inserted under env > matrix and put it there."

@NateBrady23
Copy link
Member

NateBrady23 commented Feb 6, 2023

@saru-tora Thanks, that's no longer relevant

@NateBrady23 NateBrady23 marked this pull request as ready for review February 7, 2023 14:47
@NateBrady23 NateBrady23 merged commit a3dac74 into TechEmpower:master Feb 7, 2023
fundon added a commit to fundon/FrameworkBenchmarks that referenced this pull request Feb 12, 2023
@fundon
Merge branch 'master' into viz
896dd46 
* master: (75 commits)
  Bump vertx-web from 4.1.2 to 4.3.8 in /frameworks/Prolog/tuProlog
  revert code (TechEmpower#7906)
  update spider-gazelle version and replaced orm with pg-orm (TechEmpower#7898)
  h2o_mruby: Update the dependencies and clean up the Dockerfile (TechEmpower#7903)
  Bump aahframe.work in /frameworks/Go/aah/src/benchmark (TechEmpower#7902)
  remove cached bench (TechEmpower#7900)
  Rust framework Anansi (not accepting requests from client machine) (TechEmpower#7842)
  ntex updates (TechEmpower#7899)
  http4k- upgrade http4k, java, gradle, simplify jetty loom server, tweak undertow workers (TechEmpower#7896)
  update to fiber 2.41.0 pgx 5.2.0 golang 1.2.0 (TechEmpower#7887)
  upgrade docker java and maven version (TechEmpower#7888)
  H2O: Use 64 pipelined database queries per database connection (TechEmpower#7895)
  Bump tokio from 1.21.2 to 1.24.2 in /frameworks/Rust/xitca-web (TechEmpower#7890)
  Bump tokio from 1.19.2 to 1.25.0 in /frameworks/Rust/hyper (TechEmpower#7889)
  Remove CachedWorld (TechEmpower#7894)
  Bump tokio from 1.23.0 to 1.24.2 in /frameworks/Rust/axum
  [Hexagon] Refactor and update version (TechEmpower#7885)
  improved raw fortunes performance; mORMot - fix potential GPF (TechEmpower#7883)
  mongoDB fix and updates (TechEmpower#7882)
  MySQL: Update the base image to Ubuntu 22.04 (TechEmpower#7880)
  ...
franz1981 pushed a commit to franz1981/FrameworkBenchmarks that referenced this pull request Jun 23, 2023
@saru-tora @franz1981
Rust framework Anansi (not accepting requests from client machine) (T…
412ea80 
…echEmpower#7842)

* added framework Anansi

* made server bind to 0.0.0.0

* fixed db tests

* added raw tests

* added cache test

* updated README

---------

Co-authored-by: sarutora <example.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Please Update

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saru-tora @NateBrady23 @joanhey