Conversation
|
BTW, the Travis build failure appears to be unrelated to my patch... |
|
Correct! Sorry, I meant to comment on the incoming PR's. Our travis setup doesn't have your database type available yet. Soon! |
lapis/web.lua
Outdated
There was a problem hiding this comment.
Is this correct? Don't you need to say min(500, num_queries) to ensure that this is a cap of 500? If you get sent a query=501, we expect you to return up to 500 but no more
|
You are correct, btw, it's of course |
|
Great. I'm going to cancel the travis build since it's useless here |
|
@pygy The Travis-CI verification will now work for this pull request, I added support for verifying tests that use Postgres. Add new commits or rebase onto master to trigger a new verification I went ahead and ran one verification manually, and it failed because the master branch of lapis no longer contains the Is this something you know how to fix? |
|
The problem lies here.
You can either refer to the tip or to a fixed version:
The former may be unstable, the latter will always point to The second option is IMO the way to go. @leafo, any advice on this? BTW, |
|
Second option sounds good to me too, we just need to establish what version number followed this specific commit. That lapis.sh file can be moved any time, the fw_depends doesn't care what directory its it (e.g. the directories are just to help humans organize the big list of dependencies). Thanks for pointing it out |
|
I'd pick the latest stable version. I'll submit a PR with the changes. |
|
Awesome, thank you. I was worried changing the version would break the Ps- I'll move the lapis.sh file before I merge it in. Leave that to me just |
|
Moving files with |
|
Mainly, I'd like proof that lapis works, without having to wait 5 hours until I can merge :-) It's another travis complexity that I'm working on removing as we speak. Currently if you change anything inside "toolset/", then the travis verification will run for every framework. If you only touch things inside "lapis" then it will only run a verification for lapis (whihc takes about 20-30 minutes total) |
|
I apologize your PR is being contaminated by so many Travis-CI issues....I'm working on cleaning and completing our setup a lot right now so that these complexities are removed for future pull requests |
|
Oh, wait..you need to change lapis.sh anyway. Please disregard my earlier comments and feel free to move it, I'm looking at too many PRs at once! |
|
@pygy Happy to report I've got this passing validation and should be able to merge soon, but I do have one remaining question. I had to use the I've opened an issue leafo/lapis#151 , but do you have any idea what might be happening? I would prefer to be using the specific version... |
Should this have an impact on the result, or were the queries always below 500?