[refactor/#378] Post aggregate 도메인 규칙 안전망 정리#389
Merged
Conversation
#378은 summary pipeline/embedding projection 정리 전에 Post aggregate의 직접 노출 규칙을 테스트로 잠가 이후 리팩토링에서 의도치 않은 동작 변경을 빠르게 감지하려는 안전망 작업이다. Constraint: viewCount 증가는 기존 repository atomic update 경계를 유지해야 함 Rejected: #379/#380 책임 정리를 이번 이슈에 포함 | 테스트 안전망 이슈 성격이 흐려짐 Confidence: high Scope-risk: narrow Directive: summary pipeline과 embedding projection 책임 이동은 후속 이슈에서 다뤄야 함 Tested: ./gradlew test --tests 'com.techfork.domain.post.entity.PostTest' Not-tested: summary/embedding batch 리팩토링 경로에 대한 추가 회귀 검증
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❤️ 기능 설명
Post aggregate 리팩토링 전에 직접 노출된 핵심 규칙을
PostTest로 고정했습니다.RssFeedItem -> Post.create(...)생성 규칙 검증updateSummaries(...)검증addKeyword(...),clearKeywords()검증viewCount는 기존 repository atomic update 경계를 유지연결된 issue
close #378
🩷 Approve 하기 전 확인해주세요!
updateSummary(...)제거가 후속 이슈 영향 없이 안전한지 한 번 더 봐주세요.✅ 체크리스트
테스트
./gradlew test --tests 'com.techfork.domain.post.entity.PostTest'