Skip to content

Fix review feedback from PR #11#12

Open
TechNickAI wants to merge 1 commit into
mainfrom
review-sweep/pr-11
Open

Fix review feedback from PR #11#12
TechNickAI wants to merge 1 commit into
mainfrom
review-sweep/pr-11

Conversation

@TechNickAI
Copy link
Copy Markdown
Owner

Summary

Follow-up fixes from bot review comments on PR #11 (Add Anthropic emotion research to three pages).

  • Fix AOS animation stagger: Video embed and first finding card both had data-aos-delay="100", causing simultaneous animation. Staggered cards to 200/300/400ms after video's 100ms.
  • Add noreferrer to external links: Research paper link (anthropic page) and YouTube link (for-ai-models page) now use rel="noopener noreferrer" for privacy.
  • Add referrerpolicy to iframes: Both YouTube embeds now include referrerpolicy="strict-origin-when-cross-origin".

Bot comment triage

Bot Comment Verdict Action
claude[bot] (review 1) loading="lazy" on iframes Already fixed No action needed — addressed before merge
claude[bot] (review 1) frameborder="0" deprecated Already fixed No action needed — addressed before merge
claude[bot] (review 1) Emoji aria-hidden Already fixed No action needed — addressed before merge
claude[bot] (review 2) Duplicate AOS delay Fixed Staggered card delays
claude[bot] (review 2) Missing noreferrer Fixed Added to external links
claude[bot] (review 2) iframe referrerpolicy Fixed Added to both iframes
cursor[bot] Background alternation broken Incorrect Sections correctly alternate bg-of-surfacebg-gradient-to-b

Test plan

  • Verify emotion findings cards animate in sequence (video → card 1 → card 2 → card 3) on anthropic page
  • Verify YouTube embeds still load correctly on both pages
  • Spot check external links open correctly with noreferrer

🤖 Generated with Claude Code

- Stagger AOS delays on emotion findings cards (100→200, 200→300, 300→400) to prevent simultaneous animation with video embed
- Add noreferrer to external links (research paper, YouTube) for privacy
- Add referrerpolicy="strict-origin-when-cross-origin" to both YouTube iframes

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@TechNickAI TechNickAI added review-sweep Follow-up fixes from PR review comments Hex Created by Hex labels Apr 4, 2026
@claude
Copy link
Copy Markdown

claude Bot commented Apr 4, 2026

Review of PR #12

This is a tidy, well-scoped follow-up that addresses the previous review feedback cleanly. All three changes are correct and intentional.

✅ AOS animation stagger fix (anthropic/index.html)

The fix is correct. The video embed uses data-aos-delay="100" and the three finding cards now use 200/300/400 — a clean 100ms cascade. The test plan covers this visually, which is appropriate since there's no automated way to assert animation timing.

noreferrer additions (anthropic/index.html, for-ai-models/index.html)

Both external links correctly updated from rel="noopener" to rel="noopener noreferrer". This is the right change — noreferrer also implies noopener in modern browsers, so the single attribute would suffice, but keeping both is the conventional pattern and more explicit. No issue here.

referrerpolicy on iframes (anthropic/index.html, heart-intelligence/index.html)

referrerpolicy="strict-origin-when-cross-origin" is appropriate for embedded YouTube iframes and matches the modern browser default, making the intent explicit. Consistent application across both embed instances is good.

Minor observations (non-blocking)

  • The heart-intelligence/index.html iframe change only adds referrerpolicy — it's worth confirming the external link on that page (if any) already has noreferrer, but the diff doesn't show one needing it, so this appears complete.
  • The triage table in the PR description is a helpful pattern — easy to audit what was and wasn't addressed.

Summary

All changes are correct, minimal, and well-justified. The PR description clearly traces each fix back to its source feedback. No concerns — this is ready to merge. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hex Created by Hex review-sweep Follow-up fixes from PR review comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant