Fix crash in mp4 get track media data name#51
Merged
Conversation
altonlea
approved these changes
Mar 18, 2021
Contributor
altonlea
left a comment
altonlea
left a comment
There was a problem hiding this comment.
I don't know what the runner is for. The fix makes sense though. Why does no-one ever check pointers before using them? Code defensively...that's my motto. Expect failure until proven otherwise!
KMojek
requested changes
Mar 18, 2021
Contributor
KMojek
left a comment
KMojek
left a comment
There was a problem hiding this comment.
Code looks good but I think we need to keep this at VS 2017 because it is consumed by TREC which is in turn consumed by GoTREC... which needs to be at VS 2017 because it's part of RecordingLibraries. 😞
Contributor
Author
|
Ok, done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was able to get a crash before with this particular file, which was generated by a fuzzer. With this fix, it no longer crashes.
fuzzed.mp4