chore(cliparr): enforce strict any linting#117
Merged
Conversation
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
cliparr-web | 655b110 | Commit Preview URL Branch Preview URL |
May 31 2026, 06:05 PM |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens TypeScript safety guarantees across the repo by making any usage and unsafe type flows lint errors (and removing prior provider carve-outs), while updating Plex/Jellyfin provider code to comply with the stricter rules.
Changes:
- Made
noImplicitAnyexplicit in the shared TypeScript base config. - Strengthened ESLint type-checked rules (
no-unsafe-*, redundant type constituents) and removed the Jellyfin/Plex provider exemptions. - Replaced
any-based parsing in Plex/Jellyfin providers withunknown+ narrowing and added typed Plex metadata surfaces.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.base.json | Explicitly sets noImplicitAny: true alongside strict to enforce consistent TS behavior. |
| eslint.config.js | Enforces stricter any/unsafe-flow rules and removes provider-specific rule disablements. |
| apps/server/src/providers/plex/shared.ts | Replaces any property access with unknown + runtime narrowing for persisted connection parsing. |
| apps/server/src/providers/plex/playback.ts | Introduces typed Plex metadata/session shapes to eliminate any and unsafe accesses in playback normalization. |
| apps/server/src/providers/plex/connectionState.ts | Removes any cast in plexBaseUrlMode by using typed record access. |
| apps/server/src/providers/jellyfin/shared.ts | Avoids unsafe indexed access on headers by casting to a safe record shape in the non-Headers case. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
anyand unsafe type-flow lint rules across checked TypeScript codenoImplicitAnyexplicit in the shared TypeScript configValidation
pnpm preflightNotes
Generated outputs remain excluded from lint because their generators emit
any.