Update Jellyfin bootstrap for health checks and wizard completion#16
Merged
Conversation
…izard completion status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the reliability of the Jellyfin service startup process in the development environment by ensuring that dependent services wait until Jellyfin is fully healthy or its startup wizard is completed before proceeding. The changes update both the Docker Compose configuration and the bootstrap script to better handle Jellyfin's startup state.
Service health checks:
jellyfinservice condition indocker-compose.dev.ymlfromservice_startedtoservice_healthy, ensuring that dependent services only start once Jellyfin passes its health check.Bootstrap script improvements:
startup_completed_from_public_infoand replaced the previous wait logic withwait_for_startup_ready_or_completed, which waits until either the startup wizard is completed or the/Startup/Userendpoint is available. This makes the startup process more robust and less prone to race conditions.login_jellyfin()to use the improved waiting mechanism, ensuring the script only proceeds once Jellyfin is truly ready.