[codex] Improve timeline controls UX#64
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines the frontend editor timeline UX by (a) choosing an initial zoom/scroll that focuses on the editable clip selection, (b) improving zoom anchoring behavior (buttons anchor around playhead/selection, wheel zoom stays cursor-anchored), (c) enhancing time label formatting, and (d) making mobile layout scrolling behave more naturally.
Changes:
- Adjust initial timeline zoom selection and initial scroll positioning to focus on the clip selection range.
- Improve zoom anchoring by supporting an explicit anchor time in zoom updates (while keeping wheel zoom cursor-anchored).
- Update editor time formatting to include hours and centiseconds when applicable, and tweak layout/CSS to keep controls usable.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| apps/frontend/src/index.css | Repositions timeline overlays/controls and updates container padding/background to keep zoom controls out of the ruler hit area. |
| apps/frontend/src/components/EditorScreen.tsx | Adjusts main layout overflow/min-heights for more natural mobile scrolling while keeping desktop behavior intact. |
| apps/frontend/src/components/editor/useEditorTimeline.ts | Implements focused initial zoom/scroll behavior and anchors zoom buttons around the playhead/selection. |
| apps/frontend/src/components/editor/timelineZoom.ts | Adds support for an explicit anchorTime to keep a specific time visible across zoom changes. |
| apps/frontend/src/components/editor/timelineZoom.test.ts | Extends tests for explicit anchor-time zooming, focused initial zoom selection, and updated time formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation