feat(mkapk): fix potential missing executable mode bits#59
Merged
Xe merged 2 commits intoTecharoHQ:mainfrom Nov 23, 2025
Merged
feat(mkapk): fix potential missing executable mode bits#59Xe merged 2 commits intoTecharoHQ:mainfrom
Xe merged 2 commits intoTecharoHQ:mainfrom
Conversation
kouhaidev
force-pushed
the
patch-5
branch
2 times, most recently
from
88fa769 to
942a889
Compare
if there was a strict mode, these should error. "do what i mean" is fine for now tho Signed-off-by: Kouhai <66407198+kouhaidev@users.noreply.github.com>
kouhaidev
commented
Nov 14, 2025
| platform := fmt.Sprintf("%s/%s", goos, cpu) | ||
| t.Run(platform, func(t *testing.T) { | ||
| fname := yeettest.BuildHello(t, Build, yeettest.BuildHelloInput{ | ||
| // yeettest manipulates the internal.PackageDestDir global, t.Parallel will race |
Xe
reviewed
Nov 23, 2025
Signed-off-by: Xe Iaso <me@xeiaso.net>
Xe
pushed a commit
that referenced
this pull request
Nov 23, 2025
# [0.8.0](v0.7.0...v0.8.0) (2025-11-23) ### Bug Fixes * **mkapk:** rename fields to initd/confd for consistency with alpine-sdk ([#61](#61)) ([f194f53](f194f53)), closes [#58](#58) ### Features * build confexts, portables, and sysexts ([#62](#62)) ([9aa3c2a](9aa3c2a)) * **mkapk:** expose apk packaging builtin ([#58](#58)) ([f08c123](f08c123)) * **mkapk:** fix potential missing executable mode bits ([#59](#59)) ([fd6d23e](fd6d23e)) Signed-Off-By: Mimi Yasomi <mimi@techaro.lol>
Contributor
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if there was a strict mode, these should error. "do what i mean" is fine for now tho
Checklist