Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jun 17, 2025

This PR adds search functionality to the Companies admin page, allowing administrators to search for companies by name. The implementation follows the same pattern as the existing search functionality on the public companies page.

Changes Made

  • Added search input field with placeholder text indicating minimum 2-character requirement
  • Added search and reset buttons with proper enable/disable logic
  • Implemented search logic that filters companies by name on the backend
  • Added keyboard support for triggering search with Enter key
  • Integrated with existing pagination system
  • Added unit tests to verify search functionality

UI Components Added

<input 
  type="text" 
  placeholder="Поиск по названию компании. Минимум 2 символа"
  [(ngModel)]="searchQuery"
  (keyup)="onKeyupEvent($event)" />

<button (click)="search()" [disabled]="!searchButtonShouldBeEnabled">Найти</button>
<button (click)="clearSearch()">Сбросить</button>

Backend Integration

The implementation leverages the existing CompaniesSearchParamsForAdmin interface and allForAdmin() service method, which already supported search queries:

this.service.allForAdmin({
  searchQuery: this.searchQuery || null,
  page: pageToLoad,
  pageSize: defaultPageParams.pageSize,
})

Features

  • Minimum search length: Requires at least 2 characters before enabling search
  • Real-time validation: Search button is disabled when query is too short
  • Keyboard shortcuts: Enter key triggers search
  • Reset functionality: Clear button resets search and reloads all companies
  • Pagination support: Search results work with existing pagination

The search functionality matches the UX patterns established in the public companies page, providing a consistent experience across the application.

Fixes #85.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • googlechromelabs.github.io
    • Triggering command: node install.mjs (dns block)
  • https://storage.googleapis.com/chrome-for-testing-public/133.0.6943.53/linux64/chrome-headless-shell-linux64.zip
    • Triggering command: node install.mjs (http block)
  • https://storage.googleapis.com/chrome-for-testing-public/133.0.6943.53/linux64/chrome-linux64.zip
    • Triggering command: node install.mjs (http block)

If you need me to access, download, or install something from one of these locations, you can either:


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Co-authored-by: maximgorbatyuk <13348685+maximgorbatyuk@users.noreply.github.com>
Copilot AI changed the title [WIP] Add Search by Company Name field to the Companies admin page Add Search by Company Name field to the Companies admin page Jun 17, 2025
Copilot AI requested a review from maximgorbatyuk June 17, 2025 06:13
Copilot finished work on behalf of maximgorbatyuk June 17, 2025 06:13
this.service
.allForAdmin({
searchQuery: null,
searchQuery: this.searchQuery || null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the parameter name is companyName

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the parameter name to use companyName instead of searchQuery for the admin search API as requested. Commit: 934d471

…search API

Co-authored-by: maximgorbatyuk <13348685+maximgorbatyuk@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jun 17, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • googlechromelabs.github.io
    • Triggering command: node install.mjs (dns block)
  • https://storage.googleapis.com/chrome-for-testing-public/133.0.6943.53/linux64/chrome-headless-shell-linux64.zip
    • Triggering command: node install.mjs (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot finished work on behalf of maximgorbatyuk June 17, 2025 06:27
@coderabbitai
Copy link

coderabbitai bot commented Jun 17, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@maximgorbatyuk maximgorbatyuk marked this pull request as ready for review June 17, 2025 06:47
@maximgorbatyuk maximgorbatyuk merged commit f2fabe4 into main Jun 17, 2025
1 check passed
@maximgorbatyuk maximgorbatyuk deleted the copilot/fix-85 branch June 17, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Search by Company Name field to the Companies admin page

2 participants