Skip to content

Conversation

@AlexJacksonDS
Copy link
Contributor

@AlexJacksonDS AlexJacksonDS commented Mar 23, 2022

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-647

Description

Fixes the Clear Filters button also clearing the sort and items per page for no JS.

I don't think the rest of the issues raised are to be fixed here, but if they are I'll just raise a new PR.

Screenshots

No visual changes


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

Copy link
Contributor

@DanBloxham-sw DanBloxham-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think this looks good (or as good as it can be with the SelfAssessmentOvervieviewViewModel shenanigans). One very minor comment on the unit tests.

Comment on lines 71 to 73
null,
null,
10,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, but do we want to change these, and their corresponding inputs, to something non-null just to make sure the model properties are populated?

Copy link
Contributor

@GeorgeBlackwell GeorgeBlackwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just that one comment from Dan

@AlexJacksonDS AlexJacksonDS merged commit 7898478 into master Mar 24, 2022
@AlexJacksonDS AlexJacksonDS deleted the HEEDLS-647b-refactor branch March 24, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants