HEEDLS-809 - fixed the copy course button #1037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JBsoftwire
suggested changes
Mar 25, 2022
| } | ||
|
|
||
| function defaultVoidFunction(): void { | ||
| return undefined; |
There was a problem hiding this comment.
I'm not sure it's permitted by the linter, but I'd find it neater to have an empty function rather than an undefined return. But if you think otherwise it's not important.
There was a problem hiding this comment.
Unfortunately, that was what I had first tried to go for at first, but the linter disagreed. This was the cleanest solution that I could find that pleased it.
| return element.getAttribute('data-filter-value')?.trim() ?? ''; | ||
| } | ||
|
|
||
| private displaySearchableElementsAndRunSuppliedFunction(searchableElements: ISearchableElement[]) |
There was a problem hiding this comment.
I think 'runPostDisplayFunction' or something like that would be clearer than 'runSuppliedFunction'.
There was a problem hiding this comment.
Good call. I've renamed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
https://softwiretech.atlassian.net/browse/HEEDLS-809
Description
Fixed the copy course link button to copy the course link again. Details of the issue are in the comment on the ticket.
Not sure if the modifications to the SearchSortFilterPaginate JS are the best approach here. Do let me know if you have a better suggestion.
Screenshots
N/A
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: