HEEDLS-871 Add category topic tags and fix incorrect behaviour #1098
Conversation
| return minutes < 60 ? $"{minutes}m" : $"{minutes / 60}h {minutes % 60}m"; | ||
| } | ||
|
|
||
| public static string GetTimeStringForScreenReaderFromMinutes(int minutes) |
There was a problem hiding this comment.
Do we fancy any unit tests for this?
| <table> | ||
| <tr class="header-row nhsuk-u-font-weight-bold"> | ||
| <th class="value header-row-content">Section</th> |
There was a problem hiding this comment.
The NHS tables have specific roles for different table elements. Do we want them here?
https://service-manual.nhs.uk/design-system/components/table
There was a problem hiding this comment.
I don't believe we need them since we are using the correct html elements, looking at the various bits of documentation on them e.g. https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/row_role.
e.g. I probably should have had them for the table structure with divs that I had before.
|
|
||
| public static string GetTimeStringForScreenReaderFromMinutes(int minutes) | ||
| { | ||
| return minutes < 60 ? $"{minutes} minutes" : $"{minutes / 60} hours {minutes % 60} minutes"; |
There was a problem hiding this comment.
Just double checking, I'm guessing we are fine with "1 hour 0 minutes" rather than going for just "1 hour" whenever we have a whole number of hours? Same sort of question would apply to the tag content of "1h 0m".
There was a problem hiding this comment.
I think it's fine where we have data down to the minute. Also the old site displays these as 1h 0m, and it's been to show and tell.
AlexJacksonDS
deleted the
HEEDLS-871-Learning_Content_Brand_Courses_Section
branch
JIRA link
https://softwiretech.atlassian.net/browse/HEEDLS-871
Description
Fixed some bugs with sort and filter and some screen reader issues. Added category and topic tags.
Screenshots
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: