Skip to content

Conversation

@wahedakhanam
Copy link

@wahedakhanam wahedakhanam commented May 26, 2022

JIRA link

DLSV2-530

Description

When accessing the supervisor interface, the “Staff list” should display the candidate Professional Registration Number (PRN) if the logged in user is a Supervisor.

Screenshots


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

@wahedakhanam wahedakhanam requested a review from kevwhitt-hee May 26, 2022 08:00
@kevwhitt-hee kevwhitt-hee changed the title dlsv2- Make PRN number of Staff visible for Supervisors only (not no… DLSV2-530 Make PRN number of Staff visible for Supervisors only May 26, 2022
Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See changes requested in comment.

<dd class="nhsuk-summary-list__actions">
</dd>
</div>
@if (Model.DelegateIsSupervisor)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be checking if the logged in user is a Supervisor rather than the delegate in the model. The controller should have references to this role and it may need passing to the ViewModel in order to determine visibility of PRN.

Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect now.

<dd class="nhsuk-summary-list__actions">
</dd>
</div>
@if (Model.DelegateIsSupervisor)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be checking if the logged in user is a Supervisor rather than the delegate in the model. The controller should have references to this role and it may need passing to the ViewModel in order to determine visibility of PRN.

@kevwhitt-hee kevwhitt-hee merged commit ef31709 into master Jun 8, 2022
@kevwhitt-hee kevwhitt-hee deleted the DLSV2-530 branch June 8, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants