Skip to content

Conversation

@VladNicol
Copy link
Contributor

JIRA link

HEEDLS-903

Description

For the admin registration journey, make the check that the email provided matches the AutoRegisterManagerEmail case insensitive


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

Copy link
Contributor

@simonbrent simonbrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @AlexJacksonDS has noted in Jira, this has been fixed on UAR, but because the DoesEmailMatchCentre method has been moved to a different file on UAR, it will cause a merge conflict next time master is merged into uar-test.

@VladNicol VladNicol merged commit 20ce9ae into master Jun 8, 2022
@VladNicol VladNicol deleted the HEEDLS-903-Fix-register-admin-journey-email-case-sensitivity branch June 8, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants