TD 3942 ViewDelegate Controller Refactor

[rshrirohit]

JIRA link

TD-3942

Description

1. Removed reference of the following DataServices from ViewDelegateControllerTests.cs and ViewDelegateController.cs
   using DigitalLearningSolutions.Data.DataServices;
   using DigitalLearningSolutions.Data.DataServices.UserDataService;
2. Introduced missing methods in EmailVerificationService.cs and UserService.cs

Screenshots

---

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

• Run the formatter and made sure there are no IDE errors (see info on Text Editor settings to avoid whitespace changes)
• Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
• Manually tested my work with and without JavaScript
• Tested any Views or partials created or changed with Wave Chrome plugin and addressed any valid accessibility issues
• Updated/added documentation in Confluence and/or GitHub Readme. List of documentation links added/changed:
  • doc_1_here
• Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken
• Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks.

[Auldrin-Possa]

Looks good.