Skip to content

TD-6866-Excluded logged-in supervisor ID from the supervisor list#3484

Merged
rshrirohit merged 1 commit into
DLS-Release-v1.3.0from
Develop/Fix/TD-6866-Prevent-adding-SelfSupervisor-Reportable-SA
Feb 12, 2026
Merged

TD-6866-Excluded logged-in supervisor ID from the supervisor list#3484
rshrirohit merged 1 commit into
DLS-Release-v1.3.0from
Develop/Fix/TD-6866-Prevent-adding-SelfSupervisor-Reportable-SA

Conversation

@Auldrin-Possa
Copy link
Copy Markdown
Collaborator

@Auldrin-Possa Auldrin-Possa commented Feb 10, 2026

JIRA link

TD-6866

Description

To prevent a learner from adding themselves as a supervisor on reportable self assessment, logged-in supervisor ID excluded from the supervisor list.
AdminUsers view updated to get admin user ID.
Controller code updated to exclude supervisor ID for reportable self assessment.
Affected areas in the Manage supervisors:

  1. Quick Add
  2. Add new supervisor

Screenshots

N/A


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the IDE auto formatter on all files I’ve worked on and made sure there are no IDE errors relating to them
  • Written or updated tests for the changes (accessibility ui tests for views, tests for controller, data services, services, view models created or modified) and made sure all tests are passing
  • Manually tested my work with and without JavaScript (adding notes where functionality requires JavaScript)
  • Tested any Views or partials created or changed with Wave Chrome plugin. Addressed any valid accessibility issues and documented any invalid errors
  • Updated my Jira ticket with testing notes, including information about other parts of the system that were touched as part of the MR and need to be tested to ensure nothing is broken
  • Scanned over my pull request in GitHub and addressed any warnings from the GitHub Build and Test checks in the GitHub PR ‘Files Changed’ tab
    Either:
  • Documented my work in Confluence, updating any business rules applied or modified. Updated GitHub readme/documentation for the repository if appropriate. List of documentation links added/changed:
  • Confirmed that none of the work that I have undertaken requires any updates to documentation

@Auldrin-Possa Auldrin-Possa marked this pull request as ready for review February 10, 2026 14:10
@rshrirohit rshrirohit merged commit cc8e3ed into DLS-Release-v1.3.0 Feb 12, 2026
3 checks passed
@rshrirohit rshrirohit deleted the Develop/Fix/TD-6866-Prevent-adding-SelfSupervisor-Reportable-SA branch February 12, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants