Heedls 516 group courses

[AlexJacksonDS]

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-516

Description

Adds a page to display all the courses within the group as a paginated list of NHS expanders. (counterpart of the Delegates page from HEEDLS-513)

Screenshots

---

Developer checks

I have:

• Run the formatter and made sure there are no IDE errors.
• Written tests for the changes (controller, data services, services, view models etc) and manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
• Updated/added documentation in Swiki and/or Readme.
• Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
• Scanned over my own MR to ensure everything is as expected.

[DanBloxham-sw]

Few minor comments.

[DanBloxham-sw]

Looks good to me

[stellake]

Do we ever need to filter these?

[AlexJacksonDS]

There's styles associated with this class to make tags on cards display properly

[stellake]

Should we in this case name it something different (which doesn't refer to filters and should be used more generally)?

[AlexJacksonDS]

Are you happy with the refactor of the css here? It is still slightly tied to the search/sort/paginate etc. styles

[stellake]

Given that this is not searchable page, should the pagination partial folder have a different name/should it live in a different folder (as it's more generic)?

[AlexJacksonDS]

I've refactored the pagination to pull out the logic for that into a separate BasePaginationViewModel that the old BaseSearchablePageViewModel now implements. I've not done anything about the SortOptions on this ticket, I think we should revisit that on a ticket that is actually using search/filter but not sort.

[stellake]

Looks good! 👍