Skip to content

Conversation

@livzorn
Copy link
Contributor

@livzorn livzorn commented Aug 23, 2021

JIRA link

HEEDLS-439

Description

Just a small MR to change the title of the page to Delete course admin field and remove the word 'all' from the messages on the page so they make grammatical sense when there are only 2 responses, e.g. ‘and 2 admin responses’ rather than ‘and all 2 admin responses’. I have also changed this wording on the Remove registration prompts page to make it consistent.

Screenshots

Screenshot for wording change
localhost_5001_TrackingSystem_CourseSetup_100_AdminFields_1_Remove (3)


Developer checks

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (controller, data services, services, view models etc) and manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme.
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

Copy link
Contributor

@ibrahimmunir14 ibrahimmunir14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@stellake stellake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@livzorn livzorn merged commit 9700d63 into master Aug 24, 2021
@stellake stellake deleted the HEEDLS-439-remove-course-admin-fields branch August 26, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants