HEEDLS-603 - set up supervisor delegate relation when bulk uploading … #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanBloxham-sw
commented
Sep 30, 2021
livzorn
reviewed
Oct 1, 2021
DigitalLearningSolutions.Data.Tests/Services/DelegateUploadFileServiceTests.cs
Show resolved
Hide resolved
livzorn
approved these changes
Oct 1, 2021
SteveJacksonSoft
suggested changes
Oct 6, 2021
DigitalLearningSolutions.Data/Services/DelegateUploadFileService.cs
Outdated
Show resolved
Hide resolved
| var status = registrationDataService.RegisterDelegateByCentre(model); | ||
| switch (status) | ||
| var statusOrCandidateNumber = registrationDataService.RegisterDelegateByCentre(model); | ||
| switch (statusOrCandidateNumber) |
There was a problem hiding this comment.
Ah, good point - could we just tweak this to errorCodeOrCandidateNumber? That makes it a bit clearer that it's not a candidate number when an error's occurred. Currently it's not so obvious when it's a status and when it's a candidate number. No need for re-review. Unless it demands approval before letting you merge.
There was a problem hiding this comment.
Changed to errorCodeOrCandidateNumber. No need for re-review, so I will merge it once the checks pass.
DanBloxham-sw
deleted the
HEEDLS-603-BulkUploadSupervisorDelegateRelation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…delegates
JIRA link
https://softwiretech.atlassian.net/browse/HEEDLS-603
Description
Added some calls to the supervisor delegate service during the bulk upload process for registrations.
Screenshots
N/A
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: