Skip to content

Conversation

@livzorn
Copy link
Contributor

@livzorn livzorn commented Oct 22, 2021

JIRA link

HEEDLS-443

Description

Quick fix to make the buttons in the in manage course page expandables more specific - e.g. reading out "Edit Learning Pathway defaults" rather than just "Edit".

Also changed what happens if auto-refresh is checked when the user clicks save to match the instructions in the ticket. It will now redirect back to the manage course page without saving the details. This will be changed in 442 soon to direct the user to the Edit auto-refresh options page.

Screenshots

None


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

@livzorn livzorn force-pushed the HEEDLS-443-edit-learning-pathway-defaults branch from 9f45b43 to 2e6417e Compare October 22, 2021 08:56
Copy link
Contributor

@showkath10 showkath10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@livzorn livzorn merged commit 9b1dbe6 into master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants