Skip to content

HEEDLS-443 Add aria-labels to buttons in manage course page expandables #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2021
Merged

HEEDLS-443 Add aria-labels to buttons in manage course page expandables #691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...talLearningSolutions.Web/Controllers/TrackingSystem/CourseSetup/ManageCourseController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ EditLearningPathwayDefaultsViewModel model
if (model.AutoRefresh)
{
// TODO in HEEDLS-442: Redirect to "Edit auto-refresh options" page
return RedirectToAction("Index", new { customisationId = model.CustomisationId });
}

var completeWithinMonthsInt =
Expand Down
2 changes: 1 addition & 1 deletion ...lutions.Web/Views/TrackingSystem/CourseSetup/ManageCourse/_CourseDetailsExpandable.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@

</dl>

<a class="nhsuk-button nhsuk-u-margin-right-2" role="button" href="">
<a class="nhsuk-button nhsuk-u-margin-right-2" role="button" href="" aria-label="Edit course details">
Edit
</a>

Expand Down
2 changes: 1 addition & 1 deletion ...lutions.Web/Views/TrackingSystem/CourseSetup/ManageCourse/_CourseOptionsExpandable.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
</div>
</dl>

<a class="nhsuk-button nhsuk-u-margin-right-2" role="button" href="">
<a class="nhsuk-button nhsuk-u-margin-right-2" role="button" href="" aria-label="Edit course options">
Edit
</a>

Expand Down
3 changes: 2 additions & 1 deletion ...b/Views/TrackingSystem/CourseSetup/ManageCourse/_LearningPathwayDefaultsExpandable.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,8 @@
<a class="nhsuk-button nhsuk-u-margin-right-2" role="button"
asp-controller="ManageCourse"
asp-action="EditLearningPathwayDefaults"
asp-route-customisationId="@Model.CustomisationId">
asp-route-customisationId="@Model.CustomisationId"
aria-label="Edit Learning Pathway defaults">
Edit
</a>

Expand Down