- 
                Notifications
    
You must be signed in to change notification settings  - Fork 1
 
HEEDLS-640 Add super admin centres page #727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    DanBloxham-sw
  
              
              suggested changes
              
                  
                    Nov 16, 2021 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Some minor changes can be made, and one comment that might just be me being confused.
        
          
                DigitalLearningSolutions.Web/Controllers/SuperAdmin/Centres/CentresController.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Data/DataServices/CentresDataService.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Data.Tests/Services/CentresServiceTests.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Data.Tests/DataServices/CentresDataServiceTests.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Data.Tests/DataServices/CentresDataServiceTests.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Web/Views/SuperAdmin/Centres/_CentreCard.cshtml
              
                Outdated
          
            Show resolved
            Hide resolved
        
      
              
                    DanBloxham-sw
  
              
              approved these changes
              
                  
                    Nov 17, 2021 
                  
              
              
            
            
        
          
                DigitalLearningSolutions.Web/Views/SuperAdmin/Centres/_CentreCard.cshtml
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Web/Views/SuperAdmin/Centres/_CentreCard.cshtml
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                DigitalLearningSolutions.Data.Tests/Services/CentresServiceTests.cs
              
                Outdated
          
            Show resolved
            Hide resolved
        
      
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
JIRA link
https://softwiretech.atlassian.net/browse/HEEDLS-640
Description
Adds a list all centres page to the Super Admin sub-app.
Screenshots
Desktop

Desktop expanded

Tablet

Mobile

Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: