Skip to content

Conversation

@rhimcg
Copy link
Contributor

@rhimcg rhimcg commented Nov 24, 2021

JIRA link

HEEDLS-684

Description

Add a migration to add ProfessionalRegistrationNumber and HasBeenPromptedForPrn to the candidates table

Screenshots

Attach screenshots on mobile, tablet and desktop.


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

@rhimcg rhimcg changed the base branch from master to release-22.1.1 November 24, 2021 15:54
Copy link
Contributor

@SteveJacksonSoft SteveJacksonSoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge once you've tested the Down()

@rhimcg rhimcg merged commit 4cc68a5 into release-22.1.1 Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants