Skip to content

Conversation

@ynhemanth
Copy link

@ynhemanth ynhemanth commented Nov 30, 2021

JIRA link

DLSV2-426

Description

Implements the previously missing backlinks to the breadcrumb navbar throughout the Self Assessment interface for mobile layout fallback. These are a feature of the NHS Design System Breadcrumb navigation component.

Screenshots

image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • [ y] Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • [ y] Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • [ y] Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • [ y] Scanned over my own MR to ensure everything is as expected.

@kevwhitt-hee kevwhitt-hee changed the title Added the updates DLSV2-426 Adds missing breadcrumb mobile backlinks Dec 1, 2021
Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The very first page of the self assessment (LearningPortal/SelfAssessments/SelfAssessmentDescription.html - https://localhost:44363/LearningPortal/SelfAssessment/1) is missing a backlink, though. It should have "Back to Current Activities". Without it, there is no in page way of navigating back in a mobile browser.

Copy link
Contributor

@kevwhitt-hee kevwhitt-hee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <p> tag containing the backlink was in the wrong place in the DOM. I've tweaked the Layout.cshtml file to add a placeholder for it and updated all views to ensure it sits in the placeholder. This results in the back link following the NHS design system definition and improves styling and layout.

@kevwhitt-hee kevwhitt-hee merged commit 65ba3a0 into master Dec 1, 2021
@kevwhitt-hee kevwhitt-hee deleted the Develop/feature/DLSV2-426-mobile-back-buton branch December 1, 2021 15:02
@kevwhitt-hee kevwhitt-hee restored the Develop/feature/DLSV2-426-mobile-back-buton branch December 1, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants