-
Notifications
You must be signed in to change notification settings - Fork 1
DLSV2-443 Signposting parameters flow #850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kevwhitt-hee
merged 41 commits into
master
from
Develop/Features/DLSV2-443-SignpostingParametersFlow
Jan 19, 2022
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
5b5f099
444 Set up add/edit signposting parameters flow and choose assessment…
daniel-manta-hee 0e60f2e
445 Signposting parameters choose trigger range/choose trigger option…
daniel-manta-hee dec5bf3
DLSV2-445 Signposting parameters slider to break dependencies on lear…
daniel-manta-hee fddb2dc
DLSV2-445 Signposting parameters checkbox questions, fixing bugs, etc
daniel-manta-hee 395c5a6
DLSV2-444 Signposting parameters fixes problem with Back button, navi…
daniel-manta-hee f52641e
DLSV2-446 Signposting parameters Compare result view (,mock)
daniel-manta-hee 1daa2ed
DLSV2-445 Removed BOM characters from ts file
daniel-manta-hee 5e088f1
DLSV2-462 Load data for Manage competency resource signposting view f…
daniel-manta-hee 7333beb
DLSV2-462 Removed unnecessary join as foreign keys can be used instead
daniel-manta-hee ed9c59b
DLSV2-446 Signposting parameters Compare result view
daniel-manta-hee e8797c0
DLSV2-443 Fixes problem with breadcrumbs missing after sections moved…
daniel-manta-hee 608cfa1
DLSV2-443 Replaced Back buttons for links and fixing routing, retriev…
daniel-manta-hee 2af83ea
DLSV2-445 Signposting parameters slider and checkboxes: when navigati…
daniel-manta-hee 2fdf394
DLSV2-444 Use nhs validation component for making mandatory to choose…
daniel-manta-hee e11b4aa
DLSV2-447 and DLSV2-448, including user interface and logics for sett…
daniel-manta-hee ddb49d4
Merge remote-tracking branch 'origin/master' into Develop/Features/DL…
daniel-manta-hee 3290009
DLSV2-443 Merge from master and changes for supporting database migra…
daniel-manta-hee b25749e
DLSV2-443 Implement friendly urls in all stages of the signposting pa…
daniel-manta-hee c8d3425
DLSV2-443 Allows to manage or add new resource parameters from user i…
daniel-manta-hee 1df8dea
DLSV2-443 Fixing bugs and supporting all requirements for comparing s…
daniel-manta-hee 76bcb20
Merge remote-tracking branch 'origin/master' into Develop/Features/DL…
daniel-manta-hee cddb71b
DLSV2-443 Changed summary page so it displays level descriptor labels…
daniel-manta-hee dd261fe
DLSV2-443 Minor changes
daniel-manta-hee df50feb
DLSV2-443 Fixes problem with url routing
daniel-manta-hee b42b530
DLSV2-443 Fixes bug, passing framework competency id where competency…
daniel-manta-hee 5371ce3
DLSV2-443 Fixes wrong parameter value on link, although the link shou…
daniel-manta-hee d1c7ce7
DLSV2-443 Manage different scenarios from zero to one or more questio…
daniel-manta-hee fe701a0
DLSV2-443 Amendments requested in code review for pull request 850.
daniel-manta-hee f1c1392
Fixes to typos in CompareSelfAssessmentResult.cshtml
kevwhitt-hee 1570df6
Tweaks label of status to "Optional/Recommended"
kevwhitt-hee 9abd11f
Tweak to hint text in SignpostingParametersSetTriggerValues.cshtml
kevwhitt-hee 883e3dc
Tweaks radio option label to make consistent
kevwhitt-hee 8b9c85b
DLSV2-443 Merged from master
daniel-manta-hee e8bb366
Merge branch 'Develop/Features/DLSV2-443-SignpostingParametersFlow' o…
daniel-manta-hee ef17b21
DLSV2 Bug fixing
daniel-manta-hee 94947a7
DLSV2 Fixes problem with assessment question id not mandatory in para…
daniel-manta-hee 5f80eea
DLSV2 When no role requirements are found for a question and user cli…
daniel-manta-hee fa7dcc4
Merge branch 'Develop/Features/DLSV2-443-SignpostingParametersFlow' o…
daniel-manta-hee 3a096ed
DLSV2-443 If compare to is set to role requirements or don't compare,…
daniel-manta-hee 242e0d2
DLSV2-443 Bug fixing and changed the way redirection is done dependin…
daniel-manta-hee 77fe24c
Tweak to summary title on card
kevwhitt-hee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
25 changes: 25 additions & 0 deletions
25
...604_AllowNullAssessmentQuestionIdOnTableCompetencyResourceAssessmentQuestionParameters.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| namespace DigitalLearningSolutions.Data.Migrations | ||
| { | ||
| using FluentMigrator; | ||
| [Migration(202201121604)] | ||
| public class _202201121604_AllowNullAssessmentQuestionIdOnTableCompetencyResourceAssessmentQuestionParameters : Migration | ||
| { | ||
| public override void Up() | ||
| { | ||
| Alter.Column("AssessmentQuestionID") | ||
| .OnTable("CompetencyResourceAssessmentQuestionParameters") | ||
| .AsInt32() | ||
| .Nullable(); | ||
| } | ||
| public override void Down() | ||
| { | ||
| Delete.FromTable("CompetencyResourceAssessmentQuestionParameters") | ||
| .Row(new { AssessmentQuestionID = (int?)null }); | ||
|
|
||
| Alter.Column("AssessmentQuestionID") | ||
| .OnTable("CompetencyResourceAssessmentQuestionParameters") | ||
| .AsInt32() | ||
| .NotNullable(); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
...LearningSolutions.Data/Models/Frameworks/CompetencyResourceAssessmentQuestionParameter.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Text; | ||
|
|
||
| namespace DigitalLearningSolutions.Data.Models.Frameworks | ||
| { | ||
| public class CompetencyResourceAssessmentQuestionParameter | ||
| { | ||
| public int? AssessmentQuestionId { get; set; } | ||
| public int CompetencyLearningResourceId { get; set; } | ||
| public int MinResultMatch { get; set; } | ||
| public int MaxResultMatch { get; set; } | ||
| public bool Essential { get; set; } | ||
| public int? RelevanceAssessmentQuestionId { get; set; } | ||
| public bool CompareToRoleRequirements { get; set; } | ||
| public string OriginalResourceName { get; set; } | ||
| public string Question { get; set; } | ||
| public string CompareResultTo { get; set; } | ||
| public AssessmentQuestion AssessmentQuestion { get; set; } | ||
| public AssessmentQuestion RelevanceAssessmentQuestion { get; set; } | ||
| public bool IsNew { get; set; } | ||
|
|
||
| public CompetencyResourceAssessmentQuestionParameter(bool isNew) | ||
| { | ||
| this.IsNew = isNew; | ||
| } | ||
| public CompetencyResourceAssessmentQuestionParameter() | ||
| { | ||
|
|
||
| } | ||
| } | ||
| } |
15 changes: 15 additions & 0 deletions
15
DigitalLearningSolutions.Data/Models/Frameworks/LearningResourceReference.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Text; | ||
|
|
||
| namespace DigitalLearningSolutions.Data.Models.Frameworks | ||
| { | ||
| public class LearningResourceReference | ||
| { | ||
| public int Id { get; set; } | ||
| public int ResourceRefID { get; set; } | ||
| public string OriginalResourceName { get; set; } | ||
| public int AdminID { get; set; } | ||
| public DateTime Added { get; set; } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.