Skip to content

Conversation

@DanBloxham-sw
Copy link
Contributor

@DanBloxham-sw DanBloxham-sw commented Jan 18, 2022

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-741

Description

Created two new migrations, one to undo the previous constraint-introducing migrations (depending on the state the DB is in), and one to add the new unique constraint.
I also commented out the previous migrations to prevent them from causing more errors when migrating past them. The "Undo" migration takes this into account.
I also modified one of the automated test files, as the set up of a fake server was causing errors when it tried to migrate up as it didn't have a config file to take a connection string from. I suspect it could probably be made more efficient in future.

Screenshots

N/A


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

@DanBloxham-sw DanBloxham-sw merged commit 0bb14da into master Jan 18, 2022
@DanBloxham-sw DanBloxham-sw deleted the HEEDLS-741-FixMigrationsForCompetencyAssessmentQuestionRoleRequirementsConstraints branch January 18, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants