Skip to content

Heedls 741 fix migrations for competency assessment question role requirements constraints #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 18, 2022
Merged

Heedls 741 fix migrations for competency assessment question role requirements constraints #866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9128892
Fixing migrations for CompetencyAssessmentQuestionRoleRequirements in…
DanBloxham-sw Jan 17, 2022
cee3eed
HEEDLS-741 - adjust comment and fix migration ID date
DanBloxham-sw Jan 18, 2022
13f40d2
Merge branch 'master' into Migration-fix-for-CompetencyAssessmentQues…
DanBloxham-sw Jan 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions ...a.Migrations/202201111021_ChangeCompetencyAssessmentQuestionRoleRequirementsPrimaryKey.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,25 @@
[Migration(202201111021)]
public class ChangeCompetencyAssessmentQuestionRoleRequirementsPrimaryKey: Migration
{
// This migration is undone in 202201171115_UndoPreviousConstraintMigrationsForCompetencyAssessmentQuestionRoleRequirements
// and does not need to be run again, so it has been commented out

public override void Up()
{
Delete.PrimaryKey("PK_CompetencyAssessmentQuestionRoleRequirements")
.FromTable("CompetencyAssessmentQuestionRoleRequirements");
Delete.Column("ID").FromTable("CompetencyAssessmentQuestionRoleRequirements");
Create.PrimaryKey("PK_CompetencyAssessmentQuestionRoleRequirements")
.OnTable("CompetencyAssessmentQuestionRoleRequirements").Columns("SelfAssessmentID", "CompetencyID");
//Delete.PrimaryKey("PK_CompetencyAssessmentQuestionRoleRequirements")
// .FromTable("CompetencyAssessmentQuestionRoleRequirements");
//Delete.Column("ID").FromTable("CompetencyAssessmentQuestionRoleRequirements");
//Create.PrimaryKey("PK_CompetencyAssessmentQuestionRoleRequirements")
// .OnTable("CompetencyAssessmentQuestionRoleRequirements").Columns("SelfAssessmentID", "CompetencyID");
}

public override void Down()
{
Delete.PrimaryKey("PK_CompetencyAssessmentQuestionRoleRequirements")
.FromTable("CompetencyAssessmentQuestionRoleRequirements");
Alter.Table("CompetencyAssessmentQuestionRoleRequirements").AddColumn("ID").AsInt32().NotNullable().Identity();
Create.PrimaryKey("PK_CompetencyAssessmentQuestionRoleRequirements")
.OnTable("CompetencyAssessmentQuestionRoleRequirements").Column("ID");
//Delete.PrimaryKey("PK_CompetencyAssessmentQuestionRoleRequirements")
// .FromTable("CompetencyAssessmentQuestionRoleRequirements");
//Alter.Table("CompetencyAssessmentQuestionRoleRequirements").AddColumn("ID").AsInt32().NotNullable().Identity();
//Create.PrimaryKey("PK_CompetencyAssessmentQuestionRoleRequirements")
// .OnTable("CompetencyAssessmentQuestionRoleRequirements").Column("ID");
}
}
}
31 changes: 17 additions & 14 deletions ...ons/202201120821_ChangeUniqueConstraintsOnCompetencyAssessmentQuestionRoleRequirements.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,26 +5,29 @@
[Migration(202201120821)]
public class ChangeUniqueConstraintsOnCompetencyAssessmentQuestionRoleRequirements: Migration
{
// This migration is undone in 202201171115_UndoPreviousConstraintMigrationsForCompetencyAssessmentQuestionRoleRequirements
// and does not need to be run again, so it has been commented out

public override void Up()
{
Delete.PrimaryKey("PK_CompetencyAssessmentQuestionRoleRequirements")
.FromTable("CompetencyAssessmentQuestionRoleRequirements");
Alter.Table("CompetencyAssessmentQuestionRoleRequirements").AddColumn("ID").AsInt32().NotNullable().Identity();
Create.PrimaryKey("PK_CompetencyAssessmentQuestionRoleRequirements")
.OnTable("CompetencyAssessmentQuestionRoleRequirements").Column("ID");
Create.UniqueConstraint("IX_CompetencyAssessmentQuestionRoleRequirements_SelfAssessmentID_CompetencyID")
.OnTable("CompetencyAssessmentQuestionRoleRequirements").Columns("SelfAssessmentID", "CompetencyID");
//Delete.PrimaryKey("PK_CompetencyAssessmentQuestionRoleRequirements")
// .FromTable("CompetencyAssessmentQuestionRoleRequirements");
//Alter.Table("CompetencyAssessmentQuestionRoleRequirements").AddColumn("ID").AsInt32().NotNullable().Identity();
//Create.PrimaryKey("PK_CompetencyAssessmentQuestionRoleRequirements")
// .OnTable("CompetencyAssessmentQuestionRoleRequirements").Column("ID");
//Create.UniqueConstraint("IX_CompetencyAssessmentQuestionRoleRequirements_SelfAssessmentID_CompetencyID")
// .OnTable("CompetencyAssessmentQuestionRoleRequirements").Columns("SelfAssessmentID", "CompetencyID");
}

public override void Down()
{
Delete.UniqueConstraint("IX_CompetencyAssessmentQuestionRoleRequirements_SelfAssessmentID_CompetencyID")
.FromTable("CompetencyAssessmentQuestionRoleRequirements");
Delete.PrimaryKey("PK_CompetencyAssessmentQuestionRoleRequirements")
.FromTable("CompetencyAssessmentQuestionRoleRequirements");
Delete.Column("ID").FromTable("CompetencyAssessmentQuestionRoleRequirements");
Create.PrimaryKey("PK_CompetencyAssessmentQuestionRoleRequirements")
.OnTable("CompetencyAssessmentQuestionRoleRequirements").Columns("SelfAssessmentID", "CompetencyID");
//Delete.UniqueConstraint("IX_CompetencyAssessmentQuestionRoleRequirements_SelfAssessmentID_CompetencyID")
// .FromTable("CompetencyAssessmentQuestionRoleRequirements");
//Delete.PrimaryKey("PK_CompetencyAssessmentQuestionRoleRequirements")
// .FromTable("CompetencyAssessmentQuestionRoleRequirements");
//Delete.Column("ID").FromTable("CompetencyAssessmentQuestionRoleRequirements");
//Create.PrimaryKey("PK_CompetencyAssessmentQuestionRoleRequirements")
// .OnTable("CompetencyAssessmentQuestionRoleRequirements").Columns("SelfAssessmentID", "CompetencyID");
}
}
}
37 changes: 37 additions & 0 deletions ...171115_UndoPreviousConstraintMigrationsForCompetencyAssessmentQuestionRoleRequirements.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
namespace DigitalLearningSolutions.Data.Migrations
{
using FluentMigrator;

[Migration(202201171115)]
public class UndoPreviousConstraintMigrationsForCompetencyAssessmentQuestionRoleRequirements : Migration
{
public override void Up()
{
if (Schema.Table("CompetencyAssessmentQuestionRoleRequirements").Constraint(
"IX_CompetencyAssessmentQuestionRoleRequirements_SelfAssessmentID_CompetencyID"
).Exists())
{
// This undoes the unwanted changes from 202201120821_ChangeUniqueConstraintsOnCompetencyAssessmentQuestionRoleRequirements
Delete.UniqueConstraint("IX_CompetencyAssessmentQuestionRoleRequirements_SelfAssessmentID_CompetencyID")
.FromTable("CompetencyAssessmentQuestionRoleRequirements");
}
else if (!Schema.Table("CompetencyAssessmentQuestionRoleRequirements").Column("ID").Exists())
{
// This undoes the unwanted changes from 202201111021_ChangeCompetencyAssessmentQuestionRoleRequirementsPrimaryKey
Delete.PrimaryKey("PK_CompetencyAssessmentQuestionRoleRequirements")
.FromTable("CompetencyAssessmentQuestionRoleRequirements");
Alter.Table("CompetencyAssessmentQuestionRoleRequirements").AddColumn("ID").AsInt32().NotNullable()
.Identity();
Create.PrimaryKey("PK_CompetencyAssessmentQuestionRoleRequirements")
.OnTable("CompetencyAssessmentQuestionRoleRequirements").Column("ID");
}
}

public override void Down()
{
// The Up migration reverts the database to how it should be.
// Previous migrations that should not be run have been commented out.
// Thus this Down migration does not need to do anything.
}
}
}
29 changes: 29 additions & 0 deletions ...rations/202201171130_AddUniqueConstraintToCompetencyAssessmentQuestionRoleRequirements.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
namespace DigitalLearningSolutions.Data.Migrations
{
using FluentMigrator;

[Migration(202201171130)]
public class AddUniqueConstraintToCompetencyAssessmentQuestionRoleRequirements : Migration
{
public override void Up()
{
Create.UniqueConstraint(
"IX_CompetencyAssessmentQuestionRoleRequirements_SelfAssessmentID_CompetencyID_AssessmentQuestionID_LevelValue"
)
.OnTable("CompetencyAssessmentQuestionRoleRequirements").Columns(
"SelfAssessmentID",
"CompetencyID",
"AssessmentQuestionID",
"LevelValue"
);
}

public override void Down()
{
Delete.UniqueConstraint(
"IX_CompetencyAssessmentQuestionRoleRequirements_SelfAssessmentID_CompetencyID_AssessmentQuestionID_LevelValue"
)
.FromTable("CompetencyAssessmentQuestionRoleRequirements");
}
}
}
6 changes: 5 additions & 1 deletion DigitalLearningSolutions.Web.AutomatedUiTests/SeleniumServerFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,11 @@ protected sealed override TestServer CreateServer(IWebHostBuilder builder)
RootUri = host.ServerFeatures.Get<IServerAddressesFeature>().Addresses.First();

// Fake Server to satisfy the return type
return new TestServer(new WebHostBuilder().UseStartup<TStartup>().UseSerilog());
return new TestServer(new WebHostBuilder()
.UseStartup<TStartup>()
.UseSerilog()
.ConfigureAppConfiguration(configBuilder => { configBuilder.AddConfiguration(GetConfigForUiTests()); }
));
}

protected sealed override IWebHostBuilder CreateWebHostBuilder()
Expand Down