HEEDLS-650 - Adding searching and pagination to the Recommended Learn… #876
Conversation
...lLearningSolutions.Web/Controllers/LearningPortalController/RecommendedLearningController.cs
Show resolved
Hide resolved
| public AllRecommendedLearningItemsViewModel(IEnumerable<RecommendedResource> resources, int selfAssessmentId) | ||
| { | ||
| RecommendedResources = | ||
| resources.OrderByDescending(r => r.RecommendationScore).Select(r => new SearchableRecommendedResourceViewModel(r, selfAssessmentId)); |
There was a problem hiding this comment.
Do we need the order by here? Or is this to make the javascript ordering work as expected?
There was a problem hiding this comment.
Without it, the JS ordering doesn't work properly. But that is only because I have no properly set up the JS ordering as we would expect.
We need to order based on the Recommendation Score, but we don't currently pass that through to card (only the wording for the tag). I thought that, rather than adding some hidden values to each card and setting up the SortOptions, I'd just order them in this view model first. The JS manipulation then preserves the order as it is because it doesn't have anything to sort on.
It's only a small reduction in the code necessary, and not a big time sink to implement the usual way, so I'm happy to implement that if you think it'd be better than using this workaround.
There was a problem hiding this comment.
Fair enough, I don't really thing it matters either way, so lets just leave it for now
| return competencies; | ||
| } | ||
|
|
||
| [NoCaching] |
There was a problem hiding this comment.
Just for my benefit, why do we need NoCaching?
There was a problem hiding this comment.
I was going to link the thread but realised it was in the signposting channel you don't have access to.
This tackles the drive-through bug fix in the ticket description. In short, when going through the self assessment journey, clicking some links causes the current page content to be temporarily replaced with a loading-spinner while waiting for the response for the next page. If you reach the next page, and then hit the back button, the previous page is recovered from the browser cache to display, rather than making a call to the action. Because the cache has the latest version of the page, it has the loading spinner replace all the content on that page, making it useless until you refresh the page. NoCaching just cuts out the need to refresh, as it forces the browser to always make a call to the action.
DanBloxham-sw
deleted the
HEEDLS-650-RecommendedLearningPageSearchAndPaginate
branch
…ing page
JIRA link
https://softwiretech.atlassian.net/browse/HEEDLS-650
Description
Added searching and pagination to the Recommended Learning page.
Screenshots
Desktop:
Desktop (No JS):
Tablet:
Mobile:
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have: