HEEDLS-595 test fail, fix email urls

[rhimcg]

JIRA link

HEEDLS-595

Description

little change to get the url from the config rather than the database, throw an error if what's returned is empty rather than null

Screenshots

Attach screenshots on mobile, tablet and desktop.

---

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

• Run the formatter and made sure there are no IDE errors.
• Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
• Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
• Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • doc_1_here
• Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
• Scanned over my own MR to ensure everything is as expected.

[AlexJacksonDS]

It looks to me like the testing failure was due to the incorrect config name being used
configService.GetConfigValue(ConfigHelper.CurrentSystemBaseUrlName) (I missed this when I was reviewing this before)

ConfigService gets config from the database Config table, where there is no CurrentSystemBaseUrlName, ConfigHelper gets values from appsettings, the key strings are not cross compatible.

I don't really know which the better solution is though, fixing the config key string being used, or completely stop using the ConfigService and fix the url generation bit.

[SteveJacksonSoft]

Nice, merge away