Skip to content

Conversation

@davidm-m
Copy link
Contributor

@davidm-m davidm-m commented Jan 26, 2022

…t automatic login to LH through DLS

JIRA link

HEEDLS-677

Description

Added an inset text component to the Recommended Learning page.

Screenshots

Desktop:
image
Tablet:
image
Mobile:
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

@davidm-m davidm-m marked this pull request as ready for review January 26, 2022 10:55
Copy link
Contributor

@AlexJacksonDS AlexJacksonDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but do we think that it belongs in a partial like the FallbackDataUsedWarning inset-text above? How likely are we to re-use this?

Copy link
Contributor

@SteveJacksonSoft SteveJacksonSoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question Alex. We don't plan on putting this anywhere else right now, so I think it's fine to leave as it is, and pull it into a partial if we want it somewhere else in a future phase of signposting.

@davidm-m davidm-m merged commit 5f09aeb into master Jan 26, 2022
@davidm-m davidm-m deleted the HEEDLS-677-inform-users branch January 26, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants