Skip to content

Conversation

@AlexJacksonDS
Copy link
Contributor

@AlexJacksonDS AlexJacksonDS commented Feb 25, 2022

JIRA link

https://softwiretech.atlassian.net/browse/HEEDLS-790

Description

Changed the name order on the Centre Admins, All Delegates, Group Delegates and Add delegate to group pages.
Also fixed a word wrap issue with the Add delegate to group page.

I've tidied up a few of the inconsistent name string generation usages to use the DisplayStringHelper.

Screenshots

image
image
image
image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

@AlexJacksonDS AlexJacksonDS merged commit 81e18dd into master Mar 1, 2022
@AlexJacksonDS AlexJacksonDS deleted the HEEDLS-790-change-display-names-in-lists branch March 1, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants