DLSV2-512 Make supervisor role visible on MyStaffList and AllStaffList #988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-manta-hee
changed the title
kevwhitt-hee
requested changes
Mar 4, 2022
| && loggedInAdminUser.CentreId == supervisor.CentreId | ||
| && loggedInAdminUser.EmailAddress == supervisor.SupervisorEmail | ||
| && loggedInAdminUser.Active; | ||
| return activeAdminRecordAtSameCenter && loggedInAdminUser.IsSupervisor ? DlsRole.Supervisor |
There was a problem hiding this comment.
This is getting the role (supervisor, nominated supervisor, learner) of the logged in user (the supervisor accessing the staff list interface) rather than each of the members of staff on the staff list. To get this, we will need to change the data service and model that retrieves the supervisorDelegateDetails to find matching AdminUser records for the delegate by outer joining Candidates to AdminUsers on email address, centre and active = 1 and then checking for the supervisor roles in the matched admin records.
…sNominatedSupervisor
kevwhitt-hee
approved these changes
Mar 8, 2022
kevwhitt-hee
requested changes
Mar 8, 2022
kevwhitt-hee
deleted the
Develop/Features/DLSV2-512-MakeSupervisorStatusVisible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link
https://hee-dls.atlassian.net/browse/DLSV2-512
Description
Updated Supervisor\Shared_StaffDetails.cshtml that is being called from Supervisor\Shared_StaffMemberCard.cshtml for displaying supervisor details. Only supervisors with
CandidateIDnot null would be displaying DLS role.Screenshots
Developer checks